Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron-cash: 3.1.1 -> 3.1.2 #33663

Merged
merged 1 commit into from
Jan 9, 2018
Merged

electron-cash: 3.1.1 -> 3.1.2 #33663

merged 1 commit into from
Jan 9, 2018
+2 −2

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 9, 2018

Motivation for this change

Apparently 3.1.1 didn't fix the RPC vulnerability. Hopefully this version does.
This should also be backported to older NixOS versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (none)
  • Tested compilation of all pkgs that depend on this change using (none)
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

cc @Lassulus @adisbladis

Sorry, something went wrong.

@adisbladis adisbladis self-assigned this Jan 9, 2018
@adisbladis adisbladis added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 9, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 9, 2018
@adisbladis adisbladis merged commit f1a96c5 into NixOS:master Jan 9, 2018
@adisbladis
Copy link
Member

Thanks!

Backported as 58ad926

@rnhmjoj rnhmjoj deleted the electron branch January 22, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adisbladis adisbladis

Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @adisbladis @GrahamcOfBorg