Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: fix "corrupt install" warnings, misc cleanup #33666

Closed
wants to merge 1 commit into from
Closed

discord: fix "corrupt install" warnings, misc cleanup #33666

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 9, 2018 •
edited

Few things:

  • Discord binary has RUNPATH not RPATH set
  • patchelf uses RUNPATH if it already exits, so deps end up in RUNPATH
  • RUNPATH isn't searched for plugins or transitive deps
  • ..badness results

Despite this, it currently seems to work-- with the caveat
that it has a little bar on top complaining about how
"it looks like your installation is corrupt".

This fixes that warning and does some minor cleanup.

Motivation for this change

(see above)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
discord: fix "corrupt install" warnings, misc cleanup
169d7e5 
Few things:
* Discord binary has RUNPATH not RPATH set
* patchelf uses RUNPATH if it already exits, so deps end up in RUNPATH
* RUNPATH isn't searched for plugins or transitive deps
* ..badness results

Despite this, it currently seems to work-- with the caveat
that it has a little bar on top complaining about how
"it looks like your installation is corrupt".

This fixes that warning and does some minor cleanup.
@MP2E
Copy link

MP2E commented Jan 11, 2018

Thank you for the PR and explanation! Seems I had some concepts confused :) merged to master as of 8753b10

@MP2E MP2E closed this Jan 11, 2018
@MP2E MP2E mentioned this pull request Jan 11, 2018
Closed
8 tasks
@dtzWill dtzWill deleted the fix/discord-looks-like-corrupt branch January 11, 2018 16:43
@ncfavier ncfavier mentioned this pull request Aug 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @MP2E @GrahamcOfBorg