descent 1 & 2: use assets from gog.com with the dxx-rebirth project #34611
Conversation
pkgs/top-level/all-packages.nix
Outdated
| @@ -92,6 +92,10 @@ with pkgs; | |||
| { substitutions = { gnu_config = gnu-config;}; } | |||
| ../build-support/setup-hooks/update-autotools-gnu-config-scripts.sh; | |||
|
|
|||
| gogUnpackHook = makeSetupHook | |||
There was a problem hiding this comment.
This takes a name parameter now, generally a friendly idea to use it.
peterhoeg
force-pushed
the
p/descent
branch
3 times, most recently
from
92294da
to
a7c983d
Compare
| description = "Perl extension for renaming multiple files"; | ||
| homepage = http://search.cpan.org/~rmbarker; | ||
| license = licenses.artistic1; | ||
| maintainer = with maintainers; [ peterhoeg ]; |
There was a problem hiding this comment.
maintainer isn't a valid meta field, I'm working on a fixup push. This also exposed a bug in ofborg (NixOS/ofborg#73).
There was a problem hiding this comment.
Arrghh, yes, it's maintainers. Which nix-build doesn't notice. Any thoughts on how to catch that locally?
There was a problem hiding this comment.
Thanks for fixing master!
There was a problem hiding this comment.
You might be able to put { checkMeta = true; } in your Nixpkgs configuration to catch it, otherwise I'm wanting to be able to let people run all the ofborg meta checks locally. That is a bit of a ways out though. In the mean time, I'd recommend just letting ofborg evaluate the PR before merging :) (if there is an ofborg problem, please ping me)
Motivation for this change
This contains a few items:
A couple of questions:
a. Should the "downcase the file names" logic be separated out into its own build-support tool?
b. Any better suggestions than adding "-full" for the combined assets/binary derivation?
Cc: @viric
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)