LB-303: Add instruction to add last.fm api key to custom_config.py to developement environment setup guide #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramsingh
reviewed
Feb 5, 2018
docs/dev/devel-env.rst
Outdated
| LASTFM_API_URL = "https://ws.audioscrobbler.com/2.0/" | ||
| LASTFM_API_KEY = "USE_LASTFM_API_KEY" | ||
|
|
||
| Update the last.fm api key with your key. After doing this, your |
There was a problem hiding this comment.
I think we should add a explanation on where to get this key from.
There was a problem hiding this comment.
Just adding link to API form would be enough or should i add something else too?
There was a problem hiding this comment.
You can obtain a Last.FM API key from here: <link>
docs/dev/devel-env.rst
Outdated
| @@ -111,6 +111,17 @@ Update the strings with your client ID and secret. After doing this, your | |||
| ListenBrainz development environment is able to authenticate and log in from | |||
| your MusicBrainz login. | |||
|
|
|||
| Also, in order for last.fm import to work, you should also update your last.fm api key in this file. Look for the following section in the file. | |||
There was a problem hiding this comment.
We try to write Last.FM instead of last.fm in documentation.
paramsingh
approved these changes
Feb 13, 2018
|
@mayhem, you should take a look at the verbiage here once, IMO. |
|
It doesn't flow super well, but really, there is nothing here stopping this from being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was no instruction given for adding last.fm api to custom_config.py file in the development environment setup guide.
Problem
Solution
Added the instructions to the guide.