Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.github-cli: removed #34602

Merged
merged 1 commit into from Feb 5, 2018
Merged

pythonPackages.github-cli: removed #34602

merged 1 commit into from Feb 5, 2018

Conversation

andir
Copy link
Member

@andir andir commented Feb 5, 2018

Motivation for this change

since upstream declared the project non-functional there isn't much use for this package anymore. re-adding it would be trivial.

also does not work on python3 even thought we provide it there…

Note on the upstream repo [1]:

IMPORTANT: github-cli does not function anymore since API v2 has been
replaced by API v3 A possible alternative for github-cli that addresses
API v3 is Stephen Celis' ghi

[1] https://github.com/jsmits/github-cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
pythonPackages.github-cli: removed since upstream declared project no…
b51454e 
…n-functional

also does not work on python3 even thought we provide it there…

Note on the upstream repo [1]:
> IMPORTANT: github-cli does not function anymore since API v2 has been
> replaced by API v3 A possible alternative for github-cli that addresses
> API v3 is Stephen Celis' [ghi](https://github.com/stephencelis/ghi)

[1] https://github.com/jsmits/github-cli
@andir andir requested a review from FRidh as a code owner February 5, 2018 00:56
@andir andir merged commit 35d83de into NixOS:master Feb 5, 2018
@andir andir deleted the remove-github-cli branch February 5, 2018 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg