Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix: fix config for echo/test on newer busybox #34597

Closed
wants to merge 1 commit into from
Closed

nix: fix config for echo/test on newer busybox #34597

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 4, 2018

The flags for these changes w/busybox 1.27,
and these were updated for
bootstrap tools in
#28261

and upstream:
NixOS/nix@2f1a1c5

but missed here.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 4, 2018 •
edited

Okay, so this is interesting:

Setting these properly (this PR) causes the sort of breakage behind #34592
So maybe we shouldn't?

But if so we should remove the flags since they don't do anything as-is :).

The busybox breakage happens either way, for that we need to enable arith support-- see NixOS/nix#1832 .

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


100  547k  100  547k    0     0   547k      0  0:00:01 --:--:--  0:00:01 1513k

fetching path ‘/nix/store/7i72xnpnk9w2saqcj3s0wma3wvgfgv3y-nix-1.11.16’...

*** Downloading ‘https://cache.nixos.org/nar/0qwdbj6zd0b7rl6flk3958isj7aicj436avfjnajf4ymayr9lqck.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/7i72xnpnk9w2saqcj3s0wma3wvgfgv3y-nix-1.11.16’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 61  725k   61  447k    0     0   447k      0  0:00:01 --:--:--  0:00:01 1281k
100  725k  100  725k    0     0   725k      0  0:00:01 --:--:--  0:00:01 1960k

/nix/store/7i72xnpnk9w2saqcj3s0wma3wvgfgv3y-nix-1.11.16

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/f7d4b9glzs925f700ab18krld6mvr2i8-nix-1.11.16

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/21hnahvj19sgh7rigg611blbbaa1djgz-nix-1.11.16

@dtzWill
Copy link
Member Author

dtzWill commented Feb 5, 2018

Closing in favor of #34628 .

@dtzWill dtzWill closed this Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg