Add autoStart option for Kafka and Zookeeper services #34613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus1189
force-pushed
the
kafka-zookeper-autostart
branch
from
5ff7054
to
89a1379
Compare
markus1189
force-pushed
the
kafka-zookeper-autostart
branch
from
89a1379
to
9b5ba50
Compare
|
Found a typo and tested it locally. Works for me |
|
I'm not in favor in adding an systemd.targets.openssh.wantedBy = lib.mkOverride 50 [];I would propose to either document this method or provide a more general option that works for every system (global option or function). |
|
I'm totally okay with that, it's probably better solved somewhere else than
copying the autostart option to all services.
…On Feb 10, 2018 12:18, "Jörg Thalheim" ***@***.***> wrote:
I'm not in favor in adding an autoStart option to every possible service,
we have in NixOS.
Currently it is possible to disable auto start by using:
systemd.targets.openssh.wantedBy = lib.mkOverride 50 [];
I would propose to either document this method or provide a more general
option that works for every system (global option or function).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#34613 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAkGzw4u_F9nh_n0f8re_fzkIYE3HrgOks5tTXsUgaJpZM4R5FHG>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I prefer to define them in my configuration, but not have them started automatically. I took the approach from the openvpn service and added options to disable auto start.
I tried to test this, but a
failed with:
So please take a careful look (See comment, was able to test)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)