Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R: fix dylib install_name on darwin #34209

Merged
merged 1 commit into from Jan 24, 2018
Merged

R: fix dylib install_name on darwin #34209

merged 1 commit into from Jan 24, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 23, 2018

Motivation for this change

Fixes #34202

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Jan 23, 2018
@LnL7 LnL7 requested a review from peti as a code owner January 23, 2018 23:25
@peti
Copy link
Member

peti commented Jan 24, 2018

@GrahamcOfBorg build R

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/nix/store/vxni3jvvpz6xy0cd3w7gz0wjz61fymnx-R-3.4.3

@peti peti merged commit 9ffaa69 into NixOS:master Jan 24, 2018
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

error: while evaluating the attribute 'buildInputs' of the derivation 'R-3.4.3' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u172b02' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:148:11:
No bootstrap for system

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3/lib/R/modules/R_X11.so
shrinking /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3/lib/R/modules/lapack.so
shrinking /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3/lib/R/modules/internet.so
shrinking /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3/lib/R/lib/libR.so
gzipping man pages under /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3/lib  /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3/bin 
patching script interpreter paths in /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3
checking for references to /tmp/nix-build-R-3.4.3.drv-0 in /nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3...
/nix/store/bd8fazcfbp3z3pf6pz7ymivdkxwbz5di-R-3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants