-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JRuby IRB readline issue on linux under a non-forked PTY #5005
Comments
IRB is unlikely to work properly within a PTY due to the jline library we normally use. I suspect this would work ok if you run with rb-readline which on JRuby will use true native descriptors and readline-equivalent operations. @enebo We should talk about whether to make our readline be rb-readline on platforms where we can do native IO. |
Marking for 9.2 since fixing this would likely require moving away from jline. |
@headius is there something @byteit101 could try like replace |
Move readline issues to 9.3. |
This issue is only indirectly related to IRB and has been superseded by #6552, which I discovered while fixing issues in our FFI-based io-console, which I was doing to support the new IRB. |
Environment
rspec
andffi
gems installedTest
I wrote this RSpec test that passes 3/3 on MRI, yet only passes 1/3 on JRuby:
https://gist.github.com/byteit101/241c5bb712c0d28930163ff0d88dc878
Note I had to patch PTY.open to avoid #5004
I think that the cases are fairly self explanatory, but in short it seems that IRB in some instances doesn't interactively support the arrow keys, and double echos, though if you press the keysequence blind and then hit enter, it works despite showing the escape characters.
The text was updated successfully, but these errors were encountered: