Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: d9604c861a29
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: e23b6a394b96
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Jan 23, 2018

  1. nixos/release.nix: Introduce callSubTestsOnTheseSystems 

    The existing callSubTests seems to already have special-cased code to
allow enabling subtests on a single specific system by looking at the
`system` attribute in the test arguments. Replace it with a new version
similar to the callTestOnTheseSystems because:

- It's consistent with the existing functions for creating
  system-specific tests (though admittedly, the callSubTests special
  case for `system` predates them)
- This approach allows limiting to multiple system types, the previous
  one inherently allows only one system type.
- This also fixes the problem that if you pass in e.g.
  supportedSystems = [ "aarch64-linux" ], you end up with a
  tests.chromium job that silently runs on x86_64-linux.
- Finally, this causes renames of the jobs like:
  tests.chromium -> tests.chromium.x86_64-linux to be consistent with
  the rest of the tests.
    @dezgeg
    dezgeg committed Jan 23, 2018
    Copy the full SHA
    8353ebe View commit details
    Browse the repository at this point in the history

  2. nixos/release.nix: Use callSubTestsOnTheseSystems for ec2 tests

    @dezgeg
    dezgeg committed Jan 23, 2018
    Copy the full SHA
    6388f51 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #34201 from dezgeg/release-refactor-3 

    nixos/release.nix: Introduce callSubTestsOnTheseSystems
    @Ericson2314
    Ericson2314 committed Jan 23, 2018
    Copy the full SHA
    e23b6a3 View commit details
    Browse the repository at this point in the history