Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

googlemaps: Move the .so to the right location #34219

Merged
merged 1 commit into from Jan 24, 2018
Merged

googlemaps: Move the .so to the right location #34219

merged 1 commit into from Jan 24, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jan 24, 2018 •
edited

Fixes Subsurface googlemaps plugin detection.

Motivation for this change

@flokli that fixes the problem with Subsurface on my side. I hope it also works for you :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bkchr
googlemaps: Move the .so to the right location
bf14737 
Fixes Subsurface googlemaps plugin detection.
@Mic92 Mic92 merged commit b0dd3a1 into NixOS:master Jan 24, 2018
@flokli
Copy link
Contributor

flokli commented Feb 6, 2018

@bkchr fixed this for me as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @flokli @Mic92 @GrahamcOfBorg