Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl-sdr: 0.5.3 -> 0.5.3-git #33849

Closed
wants to merge 1 commit into from
Closed

rtl-sdr: 0.5.3 -> 0.5.3-git #33849

wants to merge 1 commit into from

Conversation

markuskowa
Copy link
Member

Motivation for this change

Version 0.5.3 is already 4 years old. The latest git version contains bug fixes and feature enhancements like, e.g. bias-T control.

Things done

Tested with a RTL-SDR receiver dongle.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa mentioned this pull request Jan 14, 2018
Closed
7 tasks
@bjornfor
Copy link
Contributor

IMHO, the proper fix is to ask upstream to make a release, not for nixpkgs (or other downstreams) to bypass their QA.

@adisbladis
Copy link
Member

It would also be OK to add another -unstable attribute that overrides the rtl-sdr derivation but I don't think we should deviate from upstream releases in the rtl-sdr attribute.

@markuskowa
Copy link
Member Author

I sent out an email to the developers, asking if there's a new release on the horizon.

@markuskowa markuskowa closed this Jan 22, 2018
@markuskowa markuskowa deleted the rtlsdr-pr branch August 16, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @bjornfor @adisbladis @GrahamcOfBorg