Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: gpsbabel: Fix build with qt59 #33836

Closed
wants to merge 1 commit into from
Closed

WIP: gpsbabel: Fix build with qt59 #33836

wants to merge 1 commit into from

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jan 13, 2018 •
edited

Motivation for this change

Fixes build with Qt 5.9, some tests fail.
@rycee Could you take a look?

See Qt 5.6 deprecation issue

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis mentioned this pull request Jan 13, 2018
Closed
25 tasks
@rycee
Copy link
Member

rycee commented Jan 14, 2018

@adisbladis Nice! I will have a look during next week, hopefully tomorrow.

@rycee
Copy link
Member

rycee commented Jan 15, 2018 •
edited

Unfortunately, and unexpectedly I might add, I'm getting a bunch of test errors with the patch applied. I also tried the similar patches from Debian and Gentoo) with the same result:

…
@@ -50567,7 +50567,7 @@
         <name>TP8422</name>
       </trkpt>
       <trkpt lat="51.728183724" lon="8.736223217">
-        <ele>95.445312</ele>
+        <ele>95.445313</ele>
         <time>2013-08-15T15:18:59Z</time>
         <speed>460.833344</speed>
         <name>TP8423</name>
@@ -50609,13 +50609,13 @@
         <name>TP8429</name>
       </trkpt>
       <trkpt lat="51.728210427" lon="8.736201283">
-        <ele>95.414062</ele>
+        <ele>95.414063</ele>
         <time>2013-08-15T15:19:00Z</time>
         <speed>477.222229</speed>
         <name>TP8430</name>
       </trkpt>
       <trkpt lat="51.728214242" lon="8.736197468">
-        <ele>95.382812</ele>
+        <ele>95.382813</ele>
         <time>2013-08-15T15:19:00Z</time>
         <speed>487.222229</speed>
         <name>TP8431</name>
@@ -50633,7 +50633,7 @@
         <name>TP8433</name>
       </trkpt>
       <trkpt lat="51.728237130" lon="8.736187931">
-        <ele>95.351562</ele>
+        <ele>95.351563</ele>
         <time>2013-08-15T15:19:00Z</time>
         <speed>539.166687</speed>
         <name>TP8434</name>
@@ -50645,7 +50645,7 @@
         <name>TP8435</name>
       </trkpt>
       <trkpt lat="51.728248574" lon="8.736179348">
-        <ele>95.257812</ele>
+        <ele>95.257813</ele>
         <time>2013-08-15T15:19:00Z</time>
         <speed>548.055542</speed>
         <name>TP8436</name>
@@ -50669,7 +50669,7 @@
         <name>TP8439</name>
       </trkpt>
       <trkpt lat="51.728263833" lon="8.736165997">
-        <ele>95.195312</ele>
+        <ele>95.195313</ele>
         <time>2013-08-15T15:19:01Z</time>
         <speed>522.500000</speed>
         <name>TP8440</name>
@@ -50705,7 +50705,7 @@
         <name>TP8445</name>
       </trkpt>
       <trkpt lat="51.728286721" lon="8.736141201">
-        <ele>95.101562</ele>
+        <ele>95.101563</ele>
         <time>2013-08-15T15:19:01Z</time>
         <speed>511.944458</speed>
         <name>TP8446</name>
ERROR comparing ./reference/skytraq-miniHomer2_8.gpx /tmp/gpsbabel.7357/skytraq-miniHomer2_8.gpx
Running ./testo.d/stackfilter.test
Running ./testo.d/stmsdf.test
Running ./testo.d/stmwpp.test
Running ./testo.d/subrip.test
Running ./testo.d/tef.test
Running ./testo.d/teletype.test
Running ./testo.d/text.test
Running ./testo.d/tiger.test
Running ./testo.d/tmpro.test
Running ./testo.d/tomtom.test
Running ./testo.d/tomtom_asc.test
Running ./testo.d/tomtom_itn.test
Running ./testo.d/tpg.test
Running ./testo.d/tpo.test
Running ./testo.d/track-discard.test
Running ./testo.d/track.test
Running ./testo.d/transform.test
Running ./testo.d/unicsv.test
--- /tmp/gpsbabel.7357/unicsv_subsec.csv	2018-01-15 20:58:26.825191825 +0000
+++ ./reference/unicsv_subsec.csv	1970-01-01 00:00:01.000000000 +0000
@@ -1,12 +1,12 @@
 No,Latitude,Longitude,Name,Date,Time
-1,33.784801,-117.474350,"WPT001",2014/09/17,13:20:20.4
-2,33.784801,-117.474342,"WPT002",2014/09/17,13:20:20.6
-3,33.784801,-117.474342,"WPT003",2014/09/17,13:20:20.8
+1,33.784801,-117.474350,"WPT001",2014/09/17,13:20:20.400
+2,33.784801,-117.474342,"WPT002",2014/09/17,13:20:20.600
+3,33.784801,-117.474342,"WPT003",2014/09/17,13:20:20.800
 4,33.784801,-117.474342,"WPT004",2014/09/17,13:20:21
-5,33.784801,-117.474342,"WPT005",2014/09/17,13:20:21.2
-6,33.784801,-117.474335,"WPT006",2014/09/17,13:20:21.4
-7,33.784801,-117.474335,"WPT007",2014/09/17,13:20:21.6
-8,33.784801,-117.474335,"WPT008",2014/09/17,13:20:21.8
+5,33.784801,-117.474342,"WPT005",2014/09/17,13:20:21.200
+6,33.784801,-117.474335,"WPT006",2014/09/17,13:20:21.400
+7,33.784801,-117.474335,"WPT007",2014/09/17,13:20:21.600
+8,33.784801,-117.474335,"WPT008",2014/09/17,13:20:21.800
 9,33.784805,-117.474327,"WPT009",2014/09/17,13:20:22
-10,33.784805,-117.474327,"WPT010",2014/09/17,13:20:22.2
-11,33.784805,-117.474327,"WPT011",2014/09/17,13:20:22.4
+10,33.784805,-117.474327,"WPT010",2014/09/17,13:20:22.200
+11,33.784805,-117.474327,"WPT011",2014/09/17,13:20:22.400
ERROR comparing /tmp/gpsbabel.7357/unicsv_subsec.csv ./reference/unicsv_subsec.csv

Seems like quite an odd test error. With the existing master it builds OK. I will try to dig a bit more but I think it will have to wait until the weekend :-(

@rycee
Copy link
Member

rycee commented Jan 30, 2018

@adisbladis Sorry for being so silent on this. I've been trying to fix this when having some time left over but can't pin down the exact problem. Will continue and come with another report in the future ;-)

@adisbladis
Copy link
Member Author

@rycee I have looked through the codebase a bit and noticed some fixes in upstream related to rounding issues (GPSBabel/gpsbabel#146).

I think this may be related.

@rycee
Copy link
Member

rycee commented Feb 12, 2018

I tried applying these precision patches but they seem to rely on other commits. So I tried building gpsbabel master, which resulted in similar (but different) precision errors.

I also tried building with Qt 5.9 without any luck :-(

@GrahamcOfBorg build gpsbabel

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Running ./testo.d/wintec_tes.test
Running ./testo.d/xcsv.test
Running ./testo.d/xmap.test
Running ./testo.d/xmapwpt.test
Running ./testo.d/xol.test
Running UTF-8 BOM test
Running well-formed XML test
make: *** [Makefile:190: check] Error 15
builder for '/nix/store/xg7yikhg7c2snzzkbz0jxjq00pzmsp49-gpsbabel-1.5.4.drv' failed with exit code 2
error: build of '/nix/store/xg7yikhg7c2snzzkbz0jxjq00pzmsp49-gpsbabel-1.5.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Running ./testo.d/wintec_tes.test
Running ./testo.d/xcsv.test
Running ./testo.d/xmap.test
Running ./testo.d/xmapwpt.test
Running ./testo.d/xol.test
Running UTF-8 BOM test
Running well-formed XML test
make: *** [Makefile:190: check] Error 15
builder for ‘/nix/store/qy85vg1zsh4fdn4bhshjmbima50kpdm5-gpsbabel-1.5.4.drv’ failed with exit code 2
error: build of ‘/nix/store/qy85vg1zsh4fdn4bhshjmbima50kpdm5-gpsbabel-1.5.4.drv’ failed

@rycee
Copy link
Member

rycee commented Feb 13, 2018

@adisbladis Ok, since other distros don't seem to be too concerned about these failing tests, perhaps just disable the failing tests or disable the test suite all together?

@adisbladis adisbladis mentioned this pull request Apr 24, 2018
Closed
@adisbladis
Copy link
Member Author

I'm not feeling to good about these patches. Not sure what other subtle behaviour breaks.

I think we'll wait for upstream to make another release.

@adisbladis adisbladis closed this Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @rycee @GrahamcOfBorg @matthewbauer