Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2048-in-terminal: 2015-01-15 -> 2017-11-29 #33846

Merged
merged 1 commit into from Jan 17, 2018
Merged

2048-in-terminal: 2015-01-15 -> 2017-11-29 #33846

merged 1 commit into from Jan 17, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 14, 2018

Only functionality change AFAICT is
alewmoose/2048-in-terminal@e7595ca
which resets the board on exit at game over.

Motivation for this change

Mention on nix-devel and ended up checking for newer version than 2015. Answer is "kinda".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
2048-in-terminal: 2015-01-15 -> 2017-11-29
9058d33 
Only functionality change AFAICT is
alewmoose/2048-in-terminal@e7595ca
which resets the board on exit at game over.
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 14, 2018

Can we change the package name to not start with a digit? (see 0b16704#r14008920)
I still don't know how to properly escape it.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 14, 2018

I'd be happy to!

Need to think of a good name to use instead! Hmm....

Just thinking out loud:
I'm not sure it's worth an alias for backwards compatibility, it's a minor small package that hasn't really change in years-- and I don't want the alias to confuse nix-env like the attribute name does now.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 14, 2018

I would prefix it with an underscore. There are a few packages doing this already.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 14, 2018

@rnhmjoj done! Good call, that's nice and easy. I was debating just asking the developer if they could offer an alternative name haha :D.

@rnhmjoj rnhmjoj mentioned this pull request Jan 16, 2018
Merged
6 tasks
@orivej
Copy link
Contributor

orivej commented Jan 16, 2018

Could you keep "2048-in-terminal" as the name and optionally add _2048-in-terminal alias?

I still don't know how to properly escape it.

Currently IDs just can't begin with digits, the only way to access it is as a string attribute of the package set. (Note that nix-env -iA treats its argument as a string attribute.)

@dtzWill
Copy link
Member Author

dtzWill commented Jan 16, 2018

Dropped the name change. Let's handle the naming (or alias or (!!) Nix syntax fix) as part of the other PR.

@orivej orivej merged commit b48569d into NixOS:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @rnhmjoj @orivej @GrahamcOfBorg