Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notbit: init at 2018-01-09 #33682

Merged
merged 1 commit into from Jan 13, 2018
Merged

notbit: init at 2018-01-09 #33682

merged 1 commit into from Jan 13, 2018

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Jan 10, 2018

Motivation for this change

I wanted to use the notbit client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.


nativeBuildInputs = [ autoreconfHook pkgconfig ];

buildInputs = [ makeWrapper openssl gettext ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is makeWrapper invoked via a hook or something? Otherwise, it seems unused (and should probably be treated as native if it is used).

@mogorman
Copy link
Contributor Author

You were right. I thought mkewapper was needed to run the make command for the drv. but its removed now and worked without it

@joachifm
Copy link
Contributor

@GrahamcOfBorg build notbit

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

       ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [Makefile:566: ntb-mail-parser.o] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-notbit-2018-01-09.drv-0/source/src'
make[1]: *** [Makefile:377: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-notbit-2018-01-09.drv-0/source'
make: *** [Makefile:318: all] Error 2
builder for '/nix/store/0blhgan4vs752lsnci8jm5y6ln7zyzla-notbit-2018-01-09.drv' failed with exit code 2
error: build of '/nix/store/0blhgan4vs752lsnci8jm5y6ln7zyzla-notbit-2018-01-09.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

make[2]: Leaving directory '/tmp/nix-build-notbit-2018-01-09.drv-0/source'
make[1]: Leaving directory '/tmp/nix-build-notbit-2018-01-09.drv-0/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/73cyy46gfwqzvnpjkxax1r436cvhnw9h-notbit-2018-01-09
shrinking /nix/store/73cyy46gfwqzvnpjkxax1r436cvhnw9h-notbit-2018-01-09/bin/notbit
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/73cyy46gfwqzvnpjkxax1r436cvhnw9h-notbit-2018-01-09/bin 
patching script interpreter paths in /nix/store/73cyy46gfwqzvnpjkxax1r436cvhnw9h-notbit-2018-01-09
checking for references to /tmp/nix-build-notbit-2018-01-09.drv-0 in /nix/store/73cyy46gfwqzvnpjkxax1r436cvhnw9h-notbit-2018-01-09...
/nix/store/73cyy46gfwqzvnpjkxax1r436cvhnw9h-notbit-2018-01-09

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mh90y7ch2y3djr1m0c2hiry1s25cmdsi-notbit-2018-01-09
shrinking /nix/store/mh90y7ch2y3djr1m0c2hiry1s25cmdsi-notbit-2018-01-09/bin/notbit
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mh90y7ch2y3djr1m0c2hiry1s25cmdsi-notbit-2018-01-09/bin
patching script interpreter paths in /nix/store/mh90y7ch2y3djr1m0c2hiry1s25cmdsi-notbit-2018-01-09
checking for references to /build in /nix/store/mh90y7ch2y3djr1m0c2hiry1s25cmdsi-notbit-2018-01-09...
/nix/store/mh90y7ch2y3djr1m0c2hiry1s25cmdsi-notbit-2018-01-09

@Mic92 Mic92 merged commit ed70c59 into NixOS:master Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants