Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: Fix doCheck and doInstallCheck logic #33670

Merged
merged 1 commit into from Jan 9, 2018
Merged

stdenv: Fix doCheck and doInstallCheck logic #33670

merged 1 commit into from Jan 9, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jan 9, 2018 •
edited

Motivation for this change

It's host != build, not host != target. My mistake in #33603.

Things. done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
stdenv: Fix doCheck and doInstallCheck logic
567feb3 
It's host != build, not host != target
@Ericson2314 Ericson2314 removed the request for review from edolstra January 9, 2018 21:24
@dtzWill
Copy link
Member

dtzWill commented Jan 9, 2018

Sorry for missing this during review! Eep.

@Ericson2314 Ericson2314 merged commit c836910 into NixOS:master Jan 9, 2018
@Ericson2314 Ericson2314 deleted the cross-check branch January 9, 2018 21:37
@Ericson2314
Copy link
Member Author

NP!

@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jan 9, 2018
@Ericson2314 Ericson2314 added this to After big PR in Cross compilation Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
No open projects
Cross compilation
After big PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @dtzWill @GrahamcOfBorg