Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: add git, cleanup derivation #33677

Closed
wants to merge 4 commits into from
Closed

platformio: add git, cleanup derivation #33677

wants to merge 4 commits into from

Conversation

lukeadams
Copy link
Contributor

@lukeadams lukeadams commented Jan 9, 2018 •
edited

Motivation for this change
  • Clean up platformio FHSUserEnv builder
  • add Git input to platformio python module to allow pulling arduino libraries from git
Other notes
  • may add a note to remind users to add themselves to dialout group to allow serial port access
  • may be better to build a python.withPackages env
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukeadams lukeadams requested a review from FRidh as a code owner January 9, 2018 23:43
@lukeadams
Copy link
Contributor Author

lukeadams commented Jan 12, 2018 •
edited

Use with code on a Parallels shared folder: manual remount is required.

  1. Stop prlfsmountd.service (systemctl stop prlfsmountd.service)
  2. mount -t prl_fs ${share_name} ${desired/mnt/path}
    apparently prlfsmountd monitors fs mounts and remounts all shares if the mount options are modified
    Optionally run nixos-generate-config to add fs mount to /etc/nixos/hardware-config.nix, and maybe disable prlfsmountd entirely.

For the above I'll look into adding a NixOS parallels tools config flag for disabling the service, with a disclaimer.

@FRidh
Copy link
Member

FRidh commented Feb 3, 2018

can you rebase

@lukeadams
Copy link
Contributor Author

@FRidh 👍

@mogorman
Copy link
Contributor

mogorman commented Feb 3, 2018

looks good to me

@lukeadams lukeadams changed the title platformio improvements platformio: add git, cleanup derivation Feb 9, 2018
@FRidh
Copy link
Member

FRidh commented Feb 11, 2018

Pushed 677aa17

@FRidh FRidh closed this Feb 11, 2018
@lukeadams lukeadams deleted the pio-git branch May 26, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukeadams @FRidh @mogorman @GrahamcOfBorg