Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc, binutils: Narrow down ARM hack so only native builds are affected #33676

Merged
merged 1 commit into from Jan 9, 2018
Merged

gcc, binutils: Narrow down ARM hack so only native builds are affected #33676

merged 1 commit into from Jan 9, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

We had a bunch of cross compilation regressions when @dhess unbroke native ARM. This should unbreak cross without breaking Arm; good enough for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jan 9, 2018
@Ericson2314 Ericson2314 added this to After big PR in Cross compilation Jan 9, 2018
@dhess
Copy link
Contributor

dhess commented Jan 9, 2018

@Ericson2314 ugh, I'm really sorry! I did not expect my earlier revert to affect anything other than armv7l-linux native builds.

@Ericson2314
Copy link
Member Author

@dhess It's fine. I wrote the hack in the first place, and I didn't intend it to either! :D

@Ericson2314 Ericson2314 merged commit 98b3db2 into NixOS:master Jan 9, 2018
@Ericson2314 Ericson2314 deleted the less-arm-hack branch January 9, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
No open projects
Cross compilation
After big PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @dhess @GrahamcOfBorg