Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrainsjdk: 1036.1 ~> 1136.20 (based on build #181.4203) #33688

Merged
merged 1 commit into from Apr 8, 2018
Merged

jetbrainsjdk: 1036.1 ~> 1136.20 (based on build #181.4203) #33688

merged 1 commit into from Apr 8, 2018

Conversation

concatime
Copy link
Contributor

@concatime concatime commented Jan 10, 2018

Updating jetbrainsjdk to latest available version.

Motivation for this change

Living #YOLO, aka bleeding edge ;)

@adisbladis adisbladis changed the title 1036.1 ~> 1119.3 jetbrainsjdk: 1036.1 ~> 1119.3 Jan 10, 2018
@adisbladis
Copy link
Member

adisbladis commented Jan 10, 2018

cc @edwtjo @matklad

@concatime
Copy link
Contributor Author

Sorry for the title.

@adisbladis
Copy link
Member

Please fix commit message to include package name

@matklad
Copy link
Member

matklad commented Jan 10, 2018

I no longer work at JetBrains, but here's the useful bit of information:

The version of jdk actually used by IDEs is specified in here: https://github.com/JetBrains/intellij-community/blob/b98a9ccc6b9e5ae05b71ed855a5c91dd9f6c6587/build/dependencies/gradle.properties#L4. In general, development builds of JDK are also published to bintray, so just blindly picking the latest version from bin tray is risky. Accidentally, this is exactly what I've done initially, so, for a while, NixOS users used JDK which was more bleeding edge than anything bundled with IDEs :)

So, I think the better approach to updating here is to go to the https://www.jetbrains.com/idea/download/#section=linux, note the build number (173.4127 currently), find the corresponding branch: https://github.com/JetBrains/intellij-community/blob/173.4127/build/dependencies/gradle.properties and use the version from there jdkBuild=u152b1024.8.

@matklad
Copy link
Member

matklad commented Jan 10, 2018

cc @forantar who I believe is on the JBSDK team :)

@Mic92
Copy link
Member

Mic92 commented Jan 10, 2018

What @matklad said, sounds reasonable. So at the moment nixos is still ahead of jetbrains own versions?

@concatime
Copy link
Contributor Author

I followed the instructions provided @matklad, and fixed the message.

@concatime concatime changed the title jetbrainsjdk: 1036.1 ~> 1119.3 jetbrainsjdk: 1036.1 ~> 1136.20 (based on build #181.4203) Apr 7, 2018
@Mic92 Mic92 merged commit 5484a90 into NixOS:master Apr 8, 2018
@concatime concatime deleted the patch-1 branch April 13, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants