Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-{delegate,deploy,diff}: add top-level attributes, static #33672

Merged
merged 1 commit into from Jan 12, 2018
Merged

nix-{delegate,deploy,diff}: add top-level attributes, static #33672

merged 1 commit into from Jan 12, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 9, 2018 •
edited

Motivation for this change

Promote nix-related tools, make them more readily available for use!

(note: due to awakesecurity/nix-deploy#9 nix-deploy doesn't build for us yet-- the check marks below apply to nix-delegate only)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pbogdan
Copy link
Member

pbogdan commented Jan 10, 2018

Perhaps too niche of a use case but in the same spirit nix-diff might be worth including as well?

@dtzWill
Copy link
Member Author

dtzWill commented Jan 10, 2018

@pbogdan not too niche IMO, sounds good to me! Thanks for mentioning it! updates

@dtzWill dtzWill changed the title nix-delegate, nix-deploy: add top-level attributes nix-{delegate,deploy,diff}: add top-level attributes, static Jan 10, 2018
ixmatus
ixmatus approved these changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@ixmatus ixmatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for doing this!

Note that awakesecurity/nix-deploy#10 fixes the issue you reported.

@ixmatus
Copy link
Contributor

ixmatus commented Jan 11, 2018

CC: @Gabriel439

@ixmatus
Copy link
Contributor

ixmatus commented Jan 11, 2018 •
edited

nix-diff is definitely not too niche IMHO. I've been using it extensively in order to prove that specific changes are applied or unchanged in complicated package override scenarios and it makes for great proof collateral for those types of verifications.

@dtzWill dtzWill requested a review from peti as a code owner January 12, 2018 01:14
@dtzWill
Copy link
Member Author

dtzWill commented Jan 12, 2018

Added patch @ixmatus mentioned to fix nix-deploy while at it.

@ixmatus
Copy link
Contributor

ixmatus commented Jan 12, 2018

@dtzWill doh! I forgot to release to hackage. My bad. If I do that then you won't need the patch.

@ixmatus
Copy link
Contributor

ixmatus commented Jan 12, 2018

@dtzWill okay nix-deploy-1.0.2 is published to Hackage

@dtzWill
Copy link
Member Author

dtzWill commented Jan 12, 2018

@ixmatus okay-- dropped that commit, should be working when the next update happens. Thanks for fixing and making the release!

@peti peti merged commit f98d485 into NixOS:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixmatus ixmatus ixmatus approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @pbogdan @ixmatus @peti @GrahamcOfBorg