Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-modules: more disabled tests for armv7l-linux. #33694

Merged
merged 1 commit into from Jan 10, 2018
Merged

haskell-modules: more disabled tests for armv7l-linux. #33694

merged 1 commit into from Jan 10, 2018

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Jan 10, 2018

Specifically: servant-docs, servant-swagger, swagger2.

Motivation for this change

These Haskell packages also do not check on armv7l-linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dhess
haskell-modules: more disabled tests for armv7l-linux.
c5e433d 
Specifically: servant-docs, servant-swagger, swagger2.
@dhess dhess requested a review from peti as a code owner January 10, 2018 08:42
@dhess
Copy link
Contributor Author

dhess commented Jan 10, 2018 •
edited

Sorry, broken. I will push again in a bit.

Scratch that, the patch is fine against master. Please apply, thanks! (Hopefully the last armv7l-linux haskell-modules fix for a bit.)

@peti peti merged commit aa2d7ee into NixOS:master Jan 10, 2018
@dhess dhess deleted the more-ghc-armv7l-fixes branch January 10, 2018 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhess @peti @GrahamcOfBorg