-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notmuch: 0.25.3 -> 0.26 #33680
notmuch: 0.25.3 -> 0.26 #33680
Conversation
This was fixed upstream in f0d06c8ca3fce15c9e264445485bd93a6de8d25e, by using epg-gpg-program instead of `(call-process epg-gpg-program …)` as before.
LGTM.
|
@GrahamcOfBorg build notmuch python3Packages.notmuch python2Packages.notmuch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure for system: x86_64-darwin
0 0:00:04
0:00:04
--:--:-
- 8924
k
cannot build derivation ‘/nix/store/wxwxrzwsbz239jvpk02x18cmc57ay40h-notmuch-0.26.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/33y1fi8p4bmzrb2j830nli25q41z405w-python2.7-python-notmuch-0.26.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/10xmmfr0z4jw34z7fhigi6zzagmyalz4-python3.6-python-notmuch-0.26.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/10xmmfr0z4jw34z7fhigi6zzagmyalz4-python3.6-python-notmuch-0.26.drv’, ‘/nix/store/33y1fi8p4bmzrb2j830nli25q41z405w-python2.7-python-notmuch-0.26.drv’, ‘/nix/store/wxwxrzwsbz239jvpk02x18cmc57ay40h-notmuch-0.26.drv’ failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: x86_64-linux
writing manifest file 'notmuch.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/g241wf6hjhaxz7v53y3cqpv4kqk2x7py-notmuch-0.26
/nix/store/l8v9s1vbf5w8p550p95mc6akdl7vpybb-python3.6-python-notmuch-0.26
/nix/store/hy5p8693ljxvdwlgpn7c3fvw4vd5lil4-python2.7-python-notmuch-0.26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: aarch64-linux
writing manifest file 'notmuch.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/9sjv4bzgfzlm0amqp0g0qzip0r3fmgc8-notmuch-0.26
/nix/store/063d0mvgzdgdjyg2bcdz7fjw7ni7jiyq-python3.6-python-notmuch-0.26
/nix/store/x0b33spqmjg4n32711s41lj35ld4lrr4-python2.7-python-notmuch-0.26
@GrahamcOfBorg build notmuch python3Packages.notmuch python2Packages.notmuch retrying since the darwin build failure looks funny |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure for system: x86_64-darwin
/nix/store/10xmmfr0z4jw34z7fhigi6zzagmyalz4-python3.6-python-notmuch-0.26.drv
/nix/store/33y1fi8p4bmzrb2j830nli25q41z405w-python2.7-python-notmuch-0.26.drv
building path(s) ‘/nix/store/acn4c93dk40zmpwrkvd1jq00d39ii1cx-notmuch-0.26.tar.gz’
/nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup: fork: Operation not permitted
/nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup: fork: Operation not permitted
builder for ‘/nix/store/ilyjm12vyjs6z6s3r3hiy5zngrpx0sfv-notmuch-0.26.tar.gz.drv’ failed with exit code 254
cannot build derivation ‘/nix/store/wxwxrzwsbz239jvpk02x18cmc57ay40h-notmuch-0.26.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/33y1fi8p4bmzrb2j830nli25q41z405w-python2.7-python-notmuch-0.26.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/10xmmfr0z4jw34z7fhigi6zzagmyalz4-python3.6-python-notmuch-0.26.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/10xmmfr0z4jw34z7fhigi6zzagmyalz4-python3.6-python-notmuch-0.26.drv’, ‘/nix/store/33y1fi8p4bmzrb2j830nli25q41z405w-python2.7-python-notmuch-0.26.drv’, ‘/nix/store/wxwxrzwsbz239jvpk02x18cmc57ay40h-notmuch-0.26.drv’ failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: aarch64-linux
/nix/store/9sjv4bzgfzlm0amqp0g0qzip0r3fmgc8-notmuch-0.26
/nix/store/063d0mvgzdgdjyg2bcdz7fjw7ni7jiyq-python3.6-python-notmuch-0.26
/nix/store/x0b33spqmjg4n32711s41lj35ld4lrr4-python2.7-python-notmuch-0.26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: x86_64-linux
writing manifest file 'notmuch.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/g241wf6hjhaxz7v53y3cqpv4kqk2x7py-notmuch-0.26
/nix/store/l8v9s1vbf5w8p550p95mc6akdl7vpybb-python3.6-python-notmuch-0.26
/nix/store/hy5p8693ljxvdwlgpn7c3fvw4vd5lil4-python2.7-python-notmuch-0.26
@GrahamcOfBorg build notmuch python3Packages.notmuch python2Packages.notmuch sorry for the noise, testing a darwin fix to OfBorg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: aarch64-linux
/nix/store/9sjv4bzgfzlm0amqp0g0qzip0r3fmgc8-notmuch-0.26
/nix/store/063d0mvgzdgdjyg2bcdz7fjw7ni7jiyq-python3.6-python-notmuch-0.26
/nix/store/x0b33spqmjg4n32711s41lj35ld4lrr4-python2.7-python-notmuch-0.26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure for system: x86_64-darwin
clang-4.0: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]
ld: file not found: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error: Initial sanity checking of environment failed. Please try
running configure in a clean environment, and if the problem persists,
report a bug.
builder for '/nix/store/wxwxrzwsbz239jvpk02x18cmc57ay40h-notmuch-0.26.drv' failed with exit code 1
cannot build derivation '/nix/store/33y1fi8p4bmzrb2j830nli25q41z405w-python2.7-python-notmuch-0.26.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/10xmmfr0z4jw34z7fhigi6zzagmyalz4-python3.6-python-notmuch-0.26.drv': 1 dependencies couldn't be built
error: build of '/nix/store/10xmmfr0z4jw34z7fhigi6zzagmyalz4-python3.6-python-notmuch-0.26.drv', '/nix/store/33y1fi8p4bmzrb2j830nli25q41z405w-python2.7-python-notmuch-0.26.drv', '/nix/store/wxwxrzwsbz239jvpk02x18cmc57ay40h-notmuch-0.26.drv' failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: x86_64-linux
writing manifest file 'notmuch.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/g241wf6hjhaxz7v53y3cqpv4kqk2x7py-notmuch-0.26
/nix/store/l8v9s1vbf5w8p550p95mc6akdl7vpybb-python3.6-python-notmuch-0.26
/nix/store/hy5p8693ljxvdwlgpn7c3fvw4vd5lil4-python2.7-python-notmuch-0.26
Full build log:
|
Looks like the issue is due to purity problems on Darwin. I tried: diff --git a/pkgs/applications/networking/mailreaders/notmuch/default.nix b/pkgs/applications/networking/mailreaders/notmuch/default.nix
index 0c0f55e6337..f21e4a3f51b 100644
--- a/pkgs/applications/networking/mailreaders/notmuch/default.nix
+++ b/pkgs/applications/networking/mailreaders/notmuch/default.nix
@@ -7,6 +7,7 @@
, emacs
, ruby
, which, dtach, openssl, bash, gdb, man
+, darwin
}:
with stdenv.lib;
@@ -36,7 +37,7 @@ stdenv.mkDerivation rec {
ruby # (optional) ruby bindings
which dtach openssl bash # test dependencies
]
- ++ optional stdenv.isDarwin fixDarwinDylibNames
+ ++ optionals stdenv.isDarwin [ fixDarwinDylibNames darwin.apple_sdk.frameworks.CoreFoundation ]
++ optionals (!stdenv.isDarwin) [ gdb man ]; # test dependencies
postPatch = '' but didn't seem to help. I think we can merge as-is. |
Motivation for this change
This bumps notmuch from version 0.25.3 to 0.26, which brings a ton of new features,
including support for cleartext indexing of encrypted emails and fixes for encoding-related crashes in Python 3.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)