Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deluge: use mkEnableOption, add test #33679

Merged
merged 2 commits into from Apr 25, 2018
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 10, 2018

Motivation for this change

This updates the deluge module to use mkEnableOption and adds a nixos test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member

andir commented Jan 10, 2018

@GrahamcOfBorg test deluge

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

error: attribute ‘deluge’ in selection path ‘tests.deluge’ not found

@andir
Copy link
Member

andir commented Jan 10, 2018

@GrahamcOfBorg test deluge

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  134k  100  134k    0     0   134k      0  0:00:01 --:--:--  0:00:01  240k

fetching path ‘/nix/store/lcz15kqnmm40pwjlnlclr8m2b6gncxag-nixos-test-driver’...
fetching path ‘/nix/store/rmkxjv9p7rh2ymv5qbaq9mjrv9499hyq-python2.7-pycairo-1.15.4’...
building path(s) ‘/nix/store/xv9xbqmlzxb0b3aai73m13iy0v36r8yg-append-initrd-secrets’
killing process 25680
killing process 25678
killing process 25679
error: a ‘aarch64-linux’ is required to build ‘/nix/store/5kvcmpvrm9bd27a8rniymiq0qir035c5-append-initrd-secrets.drv’, but I am a ‘x86_64-linux’

@andir
Copy link
Member

andir commented Jan 10, 2018

@GrahamcOfBorg test deluge

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux


fetching path ‘/nix/store/5hx1kiwg3zp3is41pfyrq67bdrpym0bw-zstd-1.3.3’...

*** Downloading ‘https://nix-cache.s3.amazonaws.com/nar/1qkjk64xgv2l9rrkzaddiqf04fa3f93n31bi01yiw27cjri48x8r.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/5hx1kiwg3zp3is41pfyrq67bdrpym0bw-zstd-1.3.3’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  247k  100  247k    0     0   247k      0  0:00:01  0:00:01 --:--:--  217k
100  247k  100  247k    0     0   247k      0  0:00:01  0:00:01 --:--:--  217k

building path(s) ‘/nix/store/xv9xbqmlzxb0b3aai73m13iy0v36r8yg-append-initrd-secrets’
error: a ‘aarch64-linux’ is required to build ‘/nix/store/5kvcmpvrm9bd27a8rniymiq0qir035c5-append-initrd-secrets.drv’, but I am a ‘x86_64-linux’

@andir
Copy link
Member

andir commented Jan 10, 2018

@GrahamcOfBorg test deluge

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

cannot build derivation ‘/nix/store/jj1aavm25zmhlr7zrhgs3h5psjbgvq0n-nixos-system-server-18.03.git.4017d65.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/kzm86y61kwkfa2rji5k8i8rib6n2d7ly-closure-info.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/nl2mic9v5j39k8zk5lylszprxmhnyz25-closure-info.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/12n8fw341w73k5i6yppvv8k5amlm0m4c-run-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/9iw3xmbp8545xbqgi23hmvhcbmxwwbxx-run-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/4c4xc3wia3dsz60r8c6gqyhbp7akfli4-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/c4i4n29nilhmhvfqv7llf2gn9gjw3znz-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/5cjcpjahf6ac7cysjlz2jqj6m3pskyw3-nixos-test-driver-deluge.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/7h9dcpb85drrpzia4ibpcs7fanj7k714-vm-test-run-deluge.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/7h9dcpb85drrpzia4ibpcs7fanj7k714-vm-test-run-deluge.drv’ failed

@andir
Copy link
Member

andir commented Feb 7, 2018

@GrahamcOfBorg test deluge

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Merge failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Merge failed

@andir
Copy link
Member

andir commented Feb 7, 2018

@GrahamcOfBorg test deluge

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

server: exit status 0
client: running command: sync
client: exit status 0
test script finished in 32.42s
cleaning up
killing server (pid 627)
killing client (pid 639)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/jwy6z6r0118140qk2f85sn9g22mkjrqp-vm-test-run-deluge

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

client: exit status 0
server: running command: sync
server: exit status 0
test script finished in 16.10s
cleaning up
killing client (pid 593)
killing server (pid 604)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-deluge.drv-0/vde1.ctl': Directory not empty
/nix/store/1svqdm95rsxh6q3fk562233rrnzkn4kv-vm-test-run-deluge

@flokli
Copy link
Contributor Author

flokli commented Apr 11, 2018

@andir rebased on master. anything missing for this to get merged?

@flokli
Copy link
Contributor Author

flokli commented Apr 13, 2018

@GrahamcOfBorg test deluge

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.deluge

Partial log (click to expand)

while evaluating ‘hydraJob’ at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/lib/customisation.nix:162:14, called from /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/nixos/release.nix:23:16:
while evaluating the attribute ‘drvPath’ at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/lib/customisation.nix:179:13:
while evaluating the attribute ‘drvPath’ at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/lib/customisation.nix:146:13:
while evaluating the attribute ‘buildCommand’ of the derivation ‘vm-test-run-deluge’ at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute ‘buildCommand’ of the derivation ‘nixos-test-driver-deluge’ at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute ‘buildCommand’ of the derivation ‘nixos-vm’ at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute ‘text’ of the derivation ‘run-nixos-vm’ at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating anonymous function at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/pkgs/build-support/closure-info.nix:9:1, called from /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/nixos/modules/virtualisation/qemu-vm.nix:105:13:
assertion failed at /home/ofborg/ofborg2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c2/pkgs/build-support/closure-info.nix:11:1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.deluge

Partial log (click to expand)

cannot build derivation '/nix/store/p32kp8k2hlxfcspx7zl6ly1lv63qna54-nixos-system-server-18.09.git.fbd4ae3.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/61xd5h32bjxly55vsb2rxynfakxxmcy7-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6rhyq8zyx4cxrnwh01g0181qk9fb9m7i-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/d77xvm9vvfrb05wzzm2ip1aslfrvg8s7-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/k6s19w4qvsgwpcgyzdjgp2k7g2zp9anr-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/28hydv7vyqpfvb2i0902mkpm4n5i7f3c-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hkvxn4llq0avpcwibz15pk86xvb4l1g5-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/s4b487xxc1br5zi4n3g0ys34byi51p8i-nixos-test-driver-deluge.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/n05hcj6fwx0a3ld3i49gvcxdcv3fk3fa-vm-test-run-deluge.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/n05hcj6fwx0a3ld3i49gvcxdcv3fk3fa-vm-test-run-deluge.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: deluge

Partial log (click to expand)

/nix/store/rzl99jiy8w29z66nwd6jmqx23gvwaq85-python2.7-deluge-1.3.15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: deluge

Partial log (click to expand)

copying path '/nix/store/daw37gq1n2zxwxmjxi3cnwagnaarj6qm-python2.7-pygtk-2.24.0' from 'https://cache.nixos.org'...
copying path '/nix/store/asd49h6iq6ffxpzsn14fk0637m08kd5j-python2.7-pyxdg-0.25' from 'https://cache.nixos.org'...
copying path '/nix/store/k1dnb4ckcdpjbiiblma795h1qmqshn3x-python2.7-Automat-0.6.0' from 'https://cache.nixos.org'...
copying path '/nix/store/5ca4b0164hpxgh8cdjljwmjj67sjgism-python2.7-zope.event-4.0.3' from 'https://cache.nixos.org'...
copying path '/nix/store/z2civv4bdd4k5zn1p8g17rjafsbb99sb-python2.7-Mako-1.0.7' from 'https://cache.nixos.org'...
copying path '/nix/store/hzgxdvvyv0fb8bd53h98lixnbvcr8gha-python2.7-service_identity-17.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/2xg2blkw42aly2g559dzkvhacx5lawdd-python2.7-zope.interface-4.4.3' from 'https://cache.nixos.org'...
copying path '/nix/store/n2i6xn9dn4ijmnxwq43rrlriv6q91xxm-python2.7-Twisted-17.9.0' from 'https://cache.nixos.org'...
copying path '/nix/store/k0ix7y8fvsyxdxjphhmw59wyb8xcbcyn-python2.7-deluge-1.3.15' from 'https://cache.nixos.org'...
/nix/store/k0ix7y8fvsyxdxjphhmw59wyb8xcbcyn-python2.7-deluge-1.3.15

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: deluge

Partial log (click to expand)

warning: no previously-included files found matching 'deluge/ui/web/js/*-debug.js'
no previously-included directories found matching 'deluge/ui/web/docs'
no previously-included directories found matching 'deluge/scripts'
writing manifest file 'deluge.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

@flokli
Copy link
Contributor Author

flokli commented Apr 13, 2018

@GrahamcOfBorg test deluge

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.deluge

Partial log (click to expand)

cannot build derivation ‘/nix/store/k2p08d2i2rcydmvfi7qra57k2qzr1ipw-run-nixos-vm.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/1xqdbjn8rwkqs1mn7b4bdxqhi60ffaxh-nixos-vm.drv’: 1 dependencies couldn't be built
building path(s) ‘/nix/store/xhq5y8ksixpy59n76rg5gwxwshhanc2g-closure-info’
/nix/store/aj9rz4k3xvg8q9fzqfnb0q123707zp0n-builder: line 1: .attrs.sh: No such file or directory
builder for ‘/nix/store/45k1ii7rinp5j56hr0kwdrvh5xrm1n8d-closure-info.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/skc6w32m4dvzky98m6hh3z9jz8ks8hiv-run-nixos-vm.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/1vqqbqll2rrjc8z0ay9dchw776zr0iql-nixos-vm.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/n2pziv7k0sm98w85w7b9hhxxgvx5z15h-nixos-test-driver-deluge.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/3w16yz8cqzy960cxc7y25j95s8cmargc-vm-test-run-deluge.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/3w16yz8cqzy960cxc7y25j95s8cmargc-vm-test-run-deluge.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.deluge

Partial log (click to expand)

cannot build derivation '/nix/store/5kj5km8z8iig5v5h4cl3qsvb9c5ngfv0-nixos-system-server-18.09.git.e969307.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/4801gypvwj385zr3327jdw9sylvfk4pl-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9q8d9i7vqsyk9l2pma2akybbaikkyi00-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6hign6adsf1yikm75cqyhs8z4wp1ly4y-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/afa9ppx4300wfs7xqscmvzsz5sn1q3m1-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/j9fs4la6ffmlrx48j6907cy565f16f6v-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/pdx0sdpk5zzk2m5ziic5i0fm52g0xwy1-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ks5v0hwa77h1davxxpzhcv75vr556pk7-nixos-test-driver-deluge.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3g5w6n4ls2ac0s6mx16m3z7lp4bplrvj-vm-test-run-deluge.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/3g5w6n4ls2ac0s6mx16m3z7lp4bplrvj-vm-test-run-deluge.drv' failed

@flokli
Copy link
Contributor Author

flokli commented Apr 24, 2018

@GrahamcOfBorg test deluge

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.deluge

Partial log (click to expand)

server: exit status 0
client: running command: sync
client: exit status 0
test script finished in 15.30s
cleaning up
killing server (pid 593)
killing client (pid 604)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/2k5igj0ay10f2dvfya1fjfcx8yzsg9rp-vm-test-run-deluge

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.deluge

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7knh82i0cc1skkr6pd3z95k5i808317j-nixos-test-driver
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7knh82i0cc1skkr6pd3z95k5i808317j-nixos-test-driver/lib  /nix/store/7knh82i0cc1skkr6pd3z95k5i808317j-nixos-test-driver/bin
patching script interpreter paths in /nix/store/7knh82i0cc1skkr6pd3z95k5i808317j-nixos-test-driver
/nix/store/7knh82i0cc1skkr6pd3z95k5i808317j-nixos-test-driver/bin/.nixos-test-driver-wrapped: interpreter directive changed from " /somewhere/perl -w" to "/nix/store/3qhzffjvl8gbiabikiqdnz4jhh9v84nz-perl-5.24.3/bin/perl -w"
checking for references to /build in /nix/store/7knh82i0cc1skkr6pd3z95k5i808317j-nixos-test-driver...
cannot build derivation '/nix/store/afyr2w9x1i7ix1dc510s9aagbjd1vncf-nixos-test-driver-deluge.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/rx65xa3fkidfb4zy6g99ac9nk8z2dj7q-vm-test-run-deluge.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/rx65xa3fkidfb4zy6g99ac9nk8z2dj7q-vm-test-run-deluge.drv' failed

@matthewbauer matthewbauer merged commit e4d2d32 into NixOS:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants