Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim: don't install desktop file on darwin #33925

Merged
merged 1 commit into from Jan 16, 2018
Merged

Conversation

teto
Copy link
Member

@teto teto commented Jan 16, 2018

Motivation for this change

nvim.desktop doesn't exist on darwin so forcefully reading it fails see #33639 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nvim.desktop doesn't exist on darwin so forcefully reading it fails.
@Mic92
Copy link
Member

Mic92 commented Jan 16, 2018

@GrahamcOfBorg build neovim

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux


fetching path ‘/nix/store/74q6gfab552408isqxl4cq9z5skkxgwr-python3-3.6.4-env’...

*** Downloading ‘https://cache.nixos.org/nar/02294zr0yyhdby6jgvl5594ildn07h02nv2whagchhcmf940f1jy.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/74q6gfab552408isqxl4cq9z5skkxgwr-python3-3.6.4-env’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  4644  100  4644    0     0   4644      0  0:00:01 --:--:--  0:00:01 26386

building path(s) ‘/nix/store/h8yrsr1i8k7vwkmbsdjwanag8a669iy8-neovim’
/nix/store/h8yrsr1i8k7vwkmbsdjwanag8a669iy8-neovim

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

	/build/source/src/nvim/generators/gen_declarations.lua:232: in main chunk
	[C]: at 0x004052e0
make[2]: *** [src/nvim/CMakeFiles/nvim.dir/build.make:235: src/nvim/auto/eval/encode.c.generated.h] Error 1
make[1]: *** [CMakeFiles/Makefile2:2451: src/nvim/CMakeFiles/nvim.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  0%] Built target tty-test
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/i10zh993slykfgyl2zanw3phli4mk01l-neovim-unwrapped-0.2.1.drv' failed with exit code 2
cannot build derivation '/nix/store/4can9i4krk7qvv0bk33f820cpwr24b9k-neovim.drv': 1 dependencies couldn't be built
error: build of '/nix/store/4can9i4krk7qvv0bk33f820cpwr24b9k-neovim.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

-- Installing: /nix/store/1pyacq3ac3kgxrq8ad1zj2r1sp76qqfm-neovim-unwrapped-0.2.1/share/nvim/runtime/tutor/en/vim-01-beginner.tutor
-- Installing: /nix/store/1pyacq3ac3kgxrq8ad1zj2r1sp76qqfm-neovim-unwrapped-0.2.1/share/nvim/runtime/tutor/tutor.tutor
post-installation fixup
gzipping man pages under /nix/store/1pyacq3ac3kgxrq8ad1zj2r1sp76qqfm-neovim-unwrapped-0.2.1/share/man/
strip is /nix/store/bhfkh37smh9lc5bngdha6zx98k6w6cgd-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/1pyacq3ac3kgxrq8ad1zj2r1sp76qqfm-neovim-unwrapped-0.2.1/bin
patching script interpreter paths in /nix/store/1pyacq3ac3kgxrq8ad1zj2r1sp76qqfm-neovim-unwrapped-0.2.1
/nix/store/1pyacq3ac3kgxrq8ad1zj2r1sp76qqfm-neovim-unwrapped-0.2.1/share/nvim/runtime/macros/less.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/sh"
building '/nix/store/04rgwx6azar1sc055ap5gzjj0gyginsw-neovim.drv'...
/nix/store/27xg8jygfl8jw2clw24fh7zkny3cjvz7-neovim

@Mic92 Mic92 merged commit f9a0769 into NixOS:master Jan 16, 2018
@teto teto deleted the neovim branch May 13, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants