Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linode-api: 4.1.2b0 -> 4.1.6b0 #33928

Closed
wants to merge 1 commit into from
Closed

Conversation

GlennS
Copy link
Contributor

@GlennS GlennS commented Jan 16, 2018

Motivation for this change

Needed because the underlying HTTP endpoint has also changed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • [N/A] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"

I've run nix-shell -I "nixpkgs=." -p nox --run "nox-review wip" .

It makes result and result-2 folders for python3.6-linode-api and python2.7-linode-api. I haven't managed to import them into Python though. Presumably I need to do something with the PYTHONPATH environment variable?

  • [N/A] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Needed because the underlying HTTP endpoint has also changed.
@adisbladis
Copy link
Member

@GrahamcOfBorg build linode-api

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

error: attribute ‘linode-api’ in selection path ‘linode-api’ not found

@adisbladis
Copy link
Member

@GrahamcOfBorg build python2Packages.linode-api python3Packages.linode-api

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

Successfully installed linode-api-4.1.6b0
/tmp/nix-build-python3.6-linode-api-4.1.6b0.drv-0/linode-api-4.1.6b0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s8i6l3nsc195r2kvhhxc4c2w46d3n17x-python3.6-linode-api-4.1.6b0
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/s8i6l3nsc195r2kvhhxc4c2w46d3n17x-python3.6-linode-api-4.1.6b0/lib 
patching script interpreter paths in /nix/store/s8i6l3nsc195r2kvhhxc4c2w46d3n17x-python3.6-linode-api-4.1.6b0
checking for references to /tmp/nix-build-python3.6-linode-api-4.1.6b0.drv-0 in /nix/store/s8i6l3nsc195r2kvhhxc4c2w46d3n17x-python3.6-linode-api-4.1.6b0...
/nix/store/pq0432qwy0b9a3n040bv4s14frfbrjks-python2.7-linode-api-4.1.6b0
/nix/store/s8i6l3nsc195r2kvhhxc4c2w46d3n17x-python3.6-linode-api-4.1.6b0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

error: attribute 'linode-api' in selection path 'linode-api' not found

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

Successfully installed linode-api-4.1.6b0
/build/linode-api-4.1.6b0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/askcmigf380j0xqjibfm3h0lw4m023zv-python3.6-linode-api-4.1.6b0
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/askcmigf380j0xqjibfm3h0lw4m023zv-python3.6-linode-api-4.1.6b0/lib
patching script interpreter paths in /nix/store/askcmigf380j0xqjibfm3h0lw4m023zv-python3.6-linode-api-4.1.6b0
checking for references to /build in /nix/store/askcmigf380j0xqjibfm3h0lw4m023zv-python3.6-linode-api-4.1.6b0...
/nix/store/ry4c5sdc5p8dpfl0483qymdh18h6kp7s-python2.7-linode-api-4.1.6b0
/nix/store/askcmigf380j0xqjibfm3h0lw4m023zv-python3.6-linode-api-4.1.6b0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: attribute 'linode-api' in selection path 'linode-api' not found

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

Requirement already satisfied: idna<2.7,>=2.5 in /nix/store/34yxvl9rlxijwr7dlb330da0chbdrmqs-python3.6-idna-2.6/lib/python3.6/site-packages (from requests->linode-api==4.1.6b0)
Installing collected packages: linode-api
Successfully installed linode-api-4.1.6b0
/private/tmp/nix-build-python3.6-linode-api-4.1.6b0.drv-0/linode-api-4.1.6b0
post-installation fixup
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/9lv284i4ls4rw2a4q2p4dr3wfakjy7wr-python3.6-linode-api-4.1.6b0/lib
patching script interpreter paths in /nix/store/9lv284i4ls4rw2a4q2p4dr3wfakjy7wr-python3.6-linode-api-4.1.6b0
/nix/store/c2cl340pzvimybn161z08ss1ac2rd34a-python2.7-linode-api-4.1.6b0
/nix/store/9lv284i4ls4rw2a4q2p4dr3wfakjy7wr-python3.6-linode-api-4.1.6b0

@rbrewer123
Copy link
Contributor

I'm new to nixos and not yet familiar with the process. What else needs to happen for this PR to get merged?

@adisbladis
Copy link
Member

@rbrewer123 Just needed a reminder :)
Pushed in 2cf5f3c.

I noticed there was an even newer version available and I also enabled tests.

@adisbladis adisbladis closed this Mar 30, 2018
@rbrewer123
Copy link
Contributor

@adisbladis awesome, thanks!

@GlennS
Copy link
Contributor Author

GlennS commented Apr 5, 2018

Thanks for sorting that out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants