Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: enable shared libs #33937

Closed
wants to merge 6 commits into from
Closed

solc: enable shared libs #33937

wants to merge 6 commits into from

Conversation

akru
Copy link
Contributor

@akru akru commented Jan 16, 2018 •
edited

Motivation for this change

This change enable shared libraries build and installation for solidity compiler.
Separately added dev output for headers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@akru akru mentioned this pull request Feb 14, 2018
Closed
8 tasks
joachifm
joachifm reviewed Feb 17, 2018
View reviewed changes
pkgs/development/compilers/solc/shared_install.patch
@@ -0,0 +1,88 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this your patch or is there an external source for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my patch to enable shared solidity libraries build and install.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build solc

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

-- Installing: /nix/store/3kp1n9fz189xlmb0w0m9gpdraqbilzji-solc-0.4.19/lib/libsolidity.dylib
-- Installing: /nix/store/3kp1n9fz189xlmb0w0m9gpdraqbilzji-solc-0.4.19/bin/solc
-- Installing: /nix/store/3kp1n9fz189xlmb0w0m9gpdraqbilzji-solc-0.4.19/lib/liblll.dylib
-- Installing: /nix/store/3kp1n9fz189xlmb0w0m9gpdraqbilzji-solc-0.4.19/bin/lllc
post-installation fixup
strip is /nix/store/v8ifq0hapblpr2z0hx4wvwg02w4aczqy-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/3kp1n9fz189xlmb0w0m9gpdraqbilzji-solc-0.4.19/lib  /nix/store/3kp1n9fz189xlmb0w0m9gpdraqbilzji-solc-0.4.19/bin
patching script interpreter paths in /nix/store/3kp1n9fz189xlmb0w0m9gpdraqbilzji-solc-0.4.19
strip is /nix/store/v8ifq0hapblpr2z0hx4wvwg02w4aczqy-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/qlq9vjf5mzplmqkj9r5vg5cl4vw0dbji-solc-0.4.19-dev

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/rbfcgw8kdm076y93kwbixhk9fd4abfyk-solc-0.4.19/lib/libdevcore.so
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rbfcgw8kdm076y93kwbixhk9fd4abfyk-solc-0.4.19/lib  /nix/store/rbfcgw8kdm076y93kwbixhk9fd4abfyk-solc-0.4.19/bin
patching script interpreter paths in /nix/store/rbfcgw8kdm076y93kwbixhk9fd4abfyk-solc-0.4.19
checking for references to /build in /nix/store/rbfcgw8kdm076y93kwbixhk9fd4abfyk-solc-0.4.19...
shrinking RPATHs of ELF executables and libraries in /nix/store/b8ixhzl6yj2r3ymy4p4w50xa46hknwj4-solc-0.4.19-dev
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/b8ixhzl6yj2r3ymy4p4w50xa46hknwj4-solc-0.4.19-dev
checking for references to /build in /nix/store/b8ixhzl6yj2r3ymy4p4w50xa46hknwj4-solc-0.4.19-dev...
/nix/store/rbfcgw8kdm076y93kwbixhk9fd4abfyk-solc-0.4.19

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/nhz3gc1qsb34lyv12jmwag5bxraa5mg1-solc-0.4.19/lib/libsolidity.so
shrinking /nix/store/nhz3gc1qsb34lyv12jmwag5bxraa5mg1-solc-0.4.19/lib/libdevcore.so
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nhz3gc1qsb34lyv12jmwag5bxraa5mg1-solc-0.4.19/lib  /nix/store/nhz3gc1qsb34lyv12jmwag5bxraa5mg1-solc-0.4.19/bin 
patching script interpreter paths in /nix/store/nhz3gc1qsb34lyv12jmwag5bxraa5mg1-solc-0.4.19
checking for references to /tmp/nix-build-solc-0.4.19.drv-0 in /nix/store/nhz3gc1qsb34lyv12jmwag5bxraa5mg1-solc-0.4.19...
shrinking RPATHs of ELF executables and libraries in /nix/store/m4yhhl6yfpihx9if05lxacnwxz81cw75-solc-0.4.19-dev
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/m4yhhl6yfpihx9if05lxacnwxz81cw75-solc-0.4.19-dev
checking for references to /tmp/nix-build-solc-0.4.19.drv-0 in /nix/store/m4yhhl6yfpihx9if05lxacnwxz81cw75-solc-0.4.19-dev...

@joachifm
Copy link
Contributor

cc maintainer @dbrock

@akru
Copy link
Contributor Author

akru commented Apr 21, 2018

@joachifm how long we should waiting for the maintainer?

@joachifm
Copy link
Contributor

@akru this is long enough I reckon ... please rebase & we can integrate, if it works for you.

@akru
Copy link
Contributor Author

akru commented May 2, 2018

@joachifm rebased on #39852

@akru akru closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akru @joachifm @GrahamcOfBorg @Janik-Haag