Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cross fixes, 2 #33577

Merged
merged 6 commits into from Jan 9, 2018
Merged

Minor cross fixes, 2 #33577

merged 6 commits into from Jan 9, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 7, 2018

Motivation for this change

More evaluation and nativeBuildInputs fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 9, 2018

(cc @bgamari @Ericson2314 )

@Ericson2314 Ericson2314 changed the base branch from master to staging January 9, 2018 17:35
@Ericson2314 Ericson2314 changed the base branch from staging to master January 9, 2018 17:35
@Ericson2314
Copy link
Member

Thanks!

@Ericson2314 Ericson2314 merged commit eec050f into NixOS:master Jan 9, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Jan 9, 2018

YAAAAAAAAY!! 🎉 👍

@dtzWill dtzWill deleted the fix/cross-2 branch January 9, 2018 17:39
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jan 9, 2018
@Ericson2314 Ericson2314 added this to @bgamari's numerous fixes in Cross compilation Jan 9, 2018
@Centaurioun Centaurioun mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
No open projects
Cross compilation
@bgamari's and @dtzWill's num...
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @Ericson2314 @GrahamcOfBorg @bgamari