Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcroco: Fixes for CVE-2017-7960 & CVE-2017-7961 #33539

Merged
merged 1 commit into from Jan 7, 2018
Merged

libcroco: Fixes for CVE-2017-7960 & CVE-2017-7961 #33539

merged 1 commit into from Jan 7, 2018

Conversation

adisbladis
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @jtojnar

@adisbladis adisbladis mentioned this pull request Jan 6, 2018
Closed
46 tasks
vcunat
vcunat approved these changes Jan 7, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go to master directly, as the rebuild amount isn't that large:

Estimating rebuild amount by counting changed Hydra jobs.
     72 x86_64-darwin
    653 x86_64-linux

vcunat added a commit that referenced this pull request Jan 7, 2018
@vcunat
Merge #33539: libcroco: upstream security patches
46edf00 
CVE-2017-7960 & CVE-2017-7961

(cherry picked from commit 8154fe9)
@vcunat vcunat merged commit 3de0244 into NixOS:master Jan 7, 2018
vcunat added a commit that referenced this pull request Jan 7, 2018
@vcunat
Merge #33539: libcroco: upstream security patches
8154fe9 
CVE-2017-7960 & CVE-2017-7961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @jtojnar @vcunat @GrahamcOfBorg