Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDY] Add skim and its vim plugin #33561

Merged
merged 3 commits into from Mar 3, 2018
Merged

[RDY] Add skim and its vim plugin #33561

merged 3 commits into from Mar 3, 2018

Conversation

mnacamura
Copy link
Contributor

@mnacamura mnacamura commented Jan 7, 2018 •
edited

Motivation for this change

skim is a command-line fuzzy finder written in Rust. It is a good alternative to fzf.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mnacamura
Copy link
Contributor Author

Any feedback?

@mnacamura mnacamura mentioned this pull request Jan 16, 2018
Closed
8 tasks
@mnacamura
Copy link
Contributor Author

Confirmed that it works fine on NixOS as well as on macOS.

@teto
Copy link
Member

teto commented Jan 17, 2018

I haven't checked the vim plugin but "sk" binary installed via nix-env worked.

@magnetophon
Copy link
Member

Idk about the vim plugin either, but the sk binary works.

@mnacamura
Copy link
Contributor Author

The vim plugin works too. It should be ready to merge.

@mnacamura mnacamura changed the title Add skim 0.3.1 and its vim plugin Add skim and its vim plugin Jan 20, 2018
@magnetophon
Copy link
Member

Any news on this?

It's a very useful pkg, as you can make an interactive grep with it:

alias fzg="sk -i -c 'rg --smart-case --color always --line-number '{}'' --preview '~/.local/bin/fzg_preview.sh {0}' --ansi --reverse --bind 'alt-z:toggle-preview,alt-a:toggle-all,ctrl-a:select-all' --multi --exact --no-height --color=light"

@mnacamura mnacamura changed the title Add skim and its vim plugin [RDY] Add skim and its vim plugin Jan 24, 2018
@magnetophon
Copy link
Member

bump

@magnetophon magnetophon mentioned this pull request Feb 10, 2018
Merged
8 tasks
@mnacamura
Copy link
Contributor Author

Could anyone review and/or merge this PR?

@dywedir
Copy link
Member

dywedir commented Mar 3, 2018

@GrahamcOfBorg build skim

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/sjysd2aybigsmkscifka8hf69zifbib2-skim-0.3.2/bin 
patching script interpreter paths in /nix/store/sjysd2aybigsmkscifka8hf69zifbib2-skim-0.3.2
/nix/store/sjysd2aybigsmkscifka8hf69zifbib2-skim-0.3.2/bin/sk-share: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/sjysd2aybigsmkscifka8hf69zifbib2-skim-0.3.2/bin/sk-tmux: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-skim-0.3.2.drv-0 in /nix/store/sjysd2aybigsmkscifka8hf69zifbib2-skim-0.3.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/k816fr8zacf8hmd07h9dvzr7w8x8kvxy-skim-0.3.2-vim
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/k816fr8zacf8hmd07h9dvzr7w8x8kvxy-skim-0.3.2-vim
checking for references to /tmp/nix-build-skim-0.3.2.drv-0 in /nix/store/k816fr8zacf8hmd07h9dvzr7w8x8kvxy-skim-0.3.2-vim...
/nix/store/sjysd2aybigsmkscifka8hf69zifbib2-skim-0.3.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/w1gn2ck7wasvblx5x9g2dqnay0hsczgl-skim-0.3.2/bin
patching script interpreter paths in /nix/store/w1gn2ck7wasvblx5x9g2dqnay0hsczgl-skim-0.3.2
/nix/store/w1gn2ck7wasvblx5x9g2dqnay0hsczgl-skim-0.3.2/bin/sk-share: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/w1gn2ck7wasvblx5x9g2dqnay0hsczgl-skim-0.3.2/bin/sk-tmux: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/w1gn2ck7wasvblx5x9g2dqnay0hsczgl-skim-0.3.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/wfaaabh0v7d2yb3d4rjz975s834zx2fq-skim-0.3.2-vim
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/wfaaabh0v7d2yb3d4rjz975s834zx2fq-skim-0.3.2-vim
checking for references to /build in /nix/store/wfaaabh0v7d2yb3d4rjz975s834zx2fq-skim-0.3.2-vim...
/nix/store/w1gn2ck7wasvblx5x9g2dqnay0hsczgl-skim-0.3.2

@dywedir
Copy link
Member

dywedir commented Mar 3, 2018

@Mic92 could you please take a look?

@Mic92
Copy link
Member

Mic92 commented Mar 3, 2018

@GrahamcOfBorg build skim

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/w1gn2ck7wasvblx5x9g2dqnay0hsczgl-skim-0.3.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/build'
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/rkrwn0lnfr0s7xmi6rpy8bar48290lpp-skim-0.3.2/bin
patching script interpreter paths in /nix/store/rkrwn0lnfr0s7xmi6rpy8bar48290lpp-skim-0.3.2
/nix/store/rkrwn0lnfr0s7xmi6rpy8bar48290lpp-skim-0.3.2/bin/sk-share: interpreter directive changed from "/bin/sh" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/sh"
/nix/store/rkrwn0lnfr0s7xmi6rpy8bar48290lpp-skim-0.3.2/bin/sk-tmux: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash"
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/z2b98nl84pvwqq7lrkwjz1w0679r1mx4-skim-0.3.2-vim
/nix/store/rkrwn0lnfr0s7xmi6rpy8bar48290lpp-skim-0.3.2

@Mic92
Copy link
Member

Mic92 commented Mar 3, 2018

Yeah. Sorry for not merging this earlier. There are so many pull request...

@dywedir feel free to hit me for often, when you have a pr that is ready.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/sjysd2aybigsmkscifka8hf69zifbib2-skim-0.3.2

@Mic92 Mic92 merged commit 1fa28ae into NixOS:master Mar 3, 2018
@dywedir
Copy link
Member

dywedir commented Mar 3, 2018

Thanks!

@mnacamura
Copy link
Contributor Author

Thanks!!

@mnacamura mnacamura deleted the skim branch March 4, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mnacamura @teto @magnetophon @dywedir @GrahamcOfBorg @Mic92