Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: Remove deprecated sshd option: default is true #33567

Merged
merged 1 commit into from Mar 4, 2018
Merged

nixos: Remove deprecated sshd option: default is true #33567

merged 1 commit into from Mar 4, 2018

Conversation

michaelpj
Copy link
Contributor

Motivation for this change

Logs complain about it being deprecated - release notes indicate that it has been default true for some time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@aneeshusa
Copy link
Contributor

LGTM! (as openssh maintainer)
I actually have a version of this patch locally, looks like I never got around to posting it, so thanks for putting this in.

@michaelpj
Copy link
Contributor Author

Hm, forgot about this, can we persuade someone to merge it?

@aneeshusa
Copy link
Contributor

perhaps @Mic92 @grahamc or @fpletz might be interested in merging this?

@fpletz fpletz merged commit a66ce38 into NixOS:master Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaelpj @aneeshusa @fpletz @GrahamcOfBorg