Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum: 3.0.3 -> 3.0.4 #33548

Merged
merged 1 commit into from Jan 7, 2018
Merged

electrum: 3.0.3 -> 3.0.4 #33548

merged 1 commit into from Jan 7, 2018

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Jan 7, 2018 •
edited

From the release notes [1]:

Fix a vulnerability caused by Cross-Origin Resource Sharing (CORS)
in the JSONRPC interface. Previous versions of Electrum are
vulnerable to port scanning and deanonimization attacks from
malicious websites. Wallets that are not password-protected are
vulnerable to theft.

See this [2] for explanation.

I did not even build or test that, but wanted to notify the maintainers @ehmry @joachifm @np in the first place.

As all previous versions seem to be affected, it might be necessary to backport to 17.09? As far as I can tell, the electrum developers fixed only the recent version.

[1] https://github.com/spesmilo/electrum/blob/3.0.4/RELEASE-NOTES
[2] spesmilo/electrum#3374

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@erictapen
electrum: 3.0.3 -> 3.0.4
207bf49 
From the release notes [1]:

 * Fix a vulnerability caused by Cross-Origin Resource Sharing (CORS)
   in the JSONRPC interface. Previous versions of Electrum are
   vulnerable to port scanning and deanonimization attacks from
   malicious websites. Wallets that are not password-protected are
   vulnerable to theft.

See this [2] for explanation.

[1] https://github.com/spesmilo/electrum/blob/3.0.4/RELEASE-NOTES
[2] spesmilo/electrum#3374
@adisbladis
Copy link
Member

@GrahamcOfBorg build electrum

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 7, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: while evaluating the attribute 'propagatedBuildInputs' of the derivation 'electrum-3.0.4' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:134:11:
while evaluating the attribute 'propagatedBuildInputs' of the derivation 'python3.6-keepkey-4.0.0' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:134:11:
while evaluating the attribute 'propagatedBuildInputs' of the derivation 'python3.6-hidapi-0.7.99.post21' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:134:11:
while evaluating 'getOutput' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/attrsets.nix:450:23, called from undefined position:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:99:17, called from undefined position:
while evaluating the attribute 'udev' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/top-level/all-packages.nix:13365:3:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/top-level/all-packages.nix:13298:13:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/systemd/default.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:74:12:
assertion failed at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/systemd/default.nix:9:1

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 7, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

Successfully installed Electrum-3.0.4
/tmp/nix-build-electrum-3.0.4.drv-0/Electrum-3.0.4
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/098g78mqgch0gmgc4fvs522q685jr350-electrum-3.0.4
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/098g78mqgch0gmgc4fvs522q685jr350-electrum-3.0.4/lib  /nix/store/098g78mqgch0gmgc4fvs522q685jr350-electrum-3.0.4/bin 
patching script interpreter paths in /nix/store/098g78mqgch0gmgc4fvs522q685jr350-electrum-3.0.4
checking for references to /tmp/nix-build-electrum-3.0.4.drv-0 in /nix/store/098g78mqgch0gmgc4fvs522q685jr350-electrum-3.0.4...
wrapping `/nix/store/098g78mqgch0gmgc4fvs522q685jr350-electrum-3.0.4/bin/electrum'...
/nix/store/098g78mqgch0gmgc4fvs522q685jr350-electrum-3.0.4

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 7, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

g++ -c -pipe -DNDEBUG -DQT_IMAGE_DECODERS -DRAPIDJSON_HAS_STDSTRING=1 -DMBGL_USE_GLES2 -D__QT__ -O3 -ftemplate-depth=1024 -fvisibility-inlines-hidden -fvisibility=hidden -DMBGL_VERSION_REV=\"qt-v1.1.1\" -O2 -fPIC -std=c++1z -w -D_REENTRANT -fvisibility=hidden -fvisibility-inlines-hidden -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_DEBUG -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_SQL_LIB -DQT_CORE_LIB -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -I. -Ideps/any/8fef1e9 -Ideps/any/8fef1e9/include -Ideps/boost/1.62.0 -Ideps/boost/1.62.0/include -Ideps/cheap-ruler/2.5.3 -Ideps/cheap-ruler/2.5.3/include -Ideps/earcut/0.12.4 -Ideps/earcut/0.12.4/include -Ideps/geojson/0.4.2 -Ideps/geojson/0.4.2/include -Ideps/geojsonvt/6.3.0 -Ideps/geojsonvt/6.3.0/include -Ideps/geometry/0.9.2 -Ideps/geometry/0.9.2/include -Ideps/kdbush/0.1.1-1 -Ideps/kdbush/0.1.1-1/include -Ideps/pixelmatch/0.10.0 -Ideps/pixelmatch/0.10.0/include -Ideps/polylabel/1.0.3 -Ideps/polylabel/1.0.3/include -Ideps/protozero/1.5.2 -Ideps/protozero/1.5.2/include -Ideps/rapidjson/1.1.0 -Ideps/rapidjson/1.1.0/include -Ideps/shelf-pack/2.1.1 -Ideps/shelf-pack/2.1.1/include -Ideps/supercluster/0.2.2 -Ideps/supercluster/0.2.2/include -Ideps/unique_resource/cba309e -Ideps/unique_resource/cba309e/include -Ideps/variant/1.1.4 -Ideps/variant/1.1.4/include -Ideps/vector-tile/1.0.0-rc7 -Ideps/vector-tile/1.0.0-rc7/include -Ideps/wagyu/0.4.3 -Ideps/wagyu/0.4.3/include -Iinclude -Iplatform/default -Iplatform/qt -Iplatform/qt/include -Isrc -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork/5.9.3/QtNetwork -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui/5.9.3/QtGui -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql/5.9.3/QtSql -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore/5.9.3/QtCore -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore -I.moc -isystem /nix/store/8ksm7l0wpd0mzgs5h4wb7chq823rdqcj-mesa-noglu-17.2.8-dev/include -I/nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/mkspecs/linux-g++ -o .obj/src/mbgl/style/conversion/filter.o src/mbgl/style/conversion/filter.cpp
g++ -c -pipe -DNDEBUG -DQT_IMAGE_DECODERS -DRAPIDJSON_HAS_STDSTRING=1 -DMBGL_USE_GLES2 -D__QT__ -O3 -ftemplate-depth=1024 -fvisibility-inlines-hidden -fvisibility=hidden -DMBGL_VERSION_REV=\"qt-v1.1.1\" -O2 -fPIC -std=c++1z -w -D_REENTRANT -fvisibility=hidden -fvisibility-inlines-hidden -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_DEBUG -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_SQL_LIB -DQT_CORE_LIB -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -I. -Ideps/any/8fef1e9 -Ideps/any/8fef1e9/include -Ideps/boost/1.62.0 -Ideps/boost/1.62.0/include -Ideps/cheap-ruler/2.5.3 -Ideps/cheap-ruler/2.5.3/include -Ideps/earcut/0.12.4 -Ideps/earcut/0.12.4/include -Ideps/geojson/0.4.2 -Ideps/geojson/0.4.2/include -Ideps/geojsonvt/6.3.0 -Ideps/geojsonvt/6.3.0/include -Ideps/geometry/0.9.2 -Ideps/geometry/0.9.2/include -Ideps/kdbush/0.1.1-1 -Ideps/kdbush/0.1.1-1/include -Ideps/pixelmatch/0.10.0 -Ideps/pixelmatch/0.10.0/include -Ideps/polylabel/1.0.3 -Ideps/polylabel/1.0.3/include -Ideps/protozero/1.5.2 -Ideps/protozero/1.5.2/include -Ideps/rapidjson/1.1.0 -Ideps/rapidjson/1.1.0/include -Ideps/shelf-pack/2.1.1 -Ideps/shelf-pack/2.1.1/include -Ideps/supercluster/0.2.2 -Ideps/supercluster/0.2.2/include -Ideps/unique_resource/cba309e -Ideps/unique_resource/cba309e/include -Ideps/variant/1.1.4 -Ideps/variant/1.1.4/include -Ideps/vector-tile/1.0.0-rc7 -Ideps/vector-tile/1.0.0-rc7/include -Ideps/wagyu/0.4.3 -Ideps/wagyu/0.4.3/include -Iinclude -Iplatform/default -Iplatform/qt -Iplatform/qt/include -Isrc -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork/5.9.3/QtNetwork -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui/5.9.3/QtGui -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql/5.9.3/QtSql -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore/5.9.3/QtCore -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore -I.moc -isystem /nix/store/8ksm7l0wpd0mzgs5h4wb7chq823rdqcj-mesa-noglu-17.2.8-dev/include -I/nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/mkspecs/linux-g++ -o .obj/src/mbgl/style/conversion/geojson.o src/mbgl/style/conversion/geojson.cpp
g++ -c -pipe -DNDEBUG -DQT_IMAGE_DECODERS -DRAPIDJSON_HAS_STDSTRING=1 -DMBGL_USE_GLES2 -D__QT__ -O3 -ftemplate-depth=1024 -fvisibility-inlines-hidden -fvisibility=hidden -DMBGL_VERSION_REV=\"qt-v1.1.1\" -O2 -fPIC -std=c++1z -w -D_REENTRANT -fvisibility=hidden -fvisibility-inlines-hidden -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_DEBUG -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_SQL_LIB -DQT_CORE_LIB -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -I. -Ideps/any/8fef1e9 -Ideps/any/8fef1e9/include -Ideps/boost/1.62.0 -Ideps/boost/1.62.0/include -Ideps/cheap-ruler/2.5.3 -Ideps/cheap-ruler/2.5.3/include -Ideps/earcut/0.12.4 -Ideps/earcut/0.12.4/include -Ideps/geojson/0.4.2 -Ideps/geojson/0.4.2/include -Ideps/geojsonvt/6.3.0 -Ideps/geojsonvt/6.3.0/include -Ideps/geometry/0.9.2 -Ideps/geometry/0.9.2/include -Ideps/kdbush/0.1.1-1 -Ideps/kdbush/0.1.1-1/include -Ideps/pixelmatch/0.10.0 -Ideps/pixelmatch/0.10.0/include -Ideps/polylabel/1.0.3 -Ideps/polylabel/1.0.3/include -Ideps/protozero/1.5.2 -Ideps/protozero/1.5.2/include -Ideps/rapidjson/1.1.0 -Ideps/rapidjson/1.1.0/include -Ideps/shelf-pack/2.1.1 -Ideps/shelf-pack/2.1.1/include -Ideps/supercluster/0.2.2 -Ideps/supercluster/0.2.2/include -Ideps/unique_resource/cba309e -Ideps/unique_resource/cba309e/include -Ideps/variant/1.1.4 -Ideps/variant/1.1.4/include -Ideps/vector-tile/1.0.0-rc7 -Ideps/vector-tile/1.0.0-rc7/include -Ideps/wagyu/0.4.3 -Ideps/wagyu/0.4.3/include -Iinclude -Iplatform/default -Iplatform/qt -Iplatform/qt/include -Isrc -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork/5.9.3/QtNetwork -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui/5.9.3/QtGui -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql/5.9.3/QtSql -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore/5.9.3/QtCore -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore -I.moc -isystem /nix/store/8ksm7l0wpd0mzgs5h4wb7chq823rdqcj-mesa-noglu-17.2.8-dev/include -I/nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/mkspecs/linux-g++ -o .obj/src/mbgl/style/conversion/geojson_options.o src/mbgl/style/conversion/geojson_options.cpp
g++ -c -pipe -DNDEBUG -DQT_IMAGE_DECODERS -DRAPIDJSON_HAS_STDSTRING=1 -DMBGL_USE_GLES2 -D__QT__ -O3 -ftemplate-depth=1024 -fvisibility-inlines-hidden -fvisibility=hidden -DMBGL_VERSION_REV=\"qt-v1.1.1\" -O2 -fPIC -std=c++1z -w -D_REENTRANT -fvisibility=hidden -fvisibility-inlines-hidden -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_DEBUG -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_SQL_LIB -DQT_CORE_LIB -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -I. -Ideps/any/8fef1e9 -Ideps/any/8fef1e9/include -Ideps/boost/1.62.0 -Ideps/boost/1.62.0/include -Ideps/cheap-ruler/2.5.3 -Ideps/cheap-ruler/2.5.3/include -Ideps/earcut/0.12.4 -Ideps/earcut/0.12.4/include -Ideps/geojson/0.4.2 -Ideps/geojson/0.4.2/include -Ideps/geojsonvt/6.3.0 -Ideps/geojsonvt/6.3.0/include -Ideps/geometry/0.9.2 -Ideps/geometry/0.9.2/include -Ideps/kdbush/0.1.1-1 -Ideps/kdbush/0.1.1-1/include -Ideps/pixelmatch/0.10.0 -Ideps/pixelmatch/0.10.0/include -Ideps/polylabel/1.0.3 -Ideps/polylabel/1.0.3/include -Ideps/protozero/1.5.2 -Ideps/protozero/1.5.2/include -Ideps/rapidjson/1.1.0 -Ideps/rapidjson/1.1.0/include -Ideps/shelf-pack/2.1.1 -Ideps/shelf-pack/2.1.1/include -Ideps/supercluster/0.2.2 -Ideps/supercluster/0.2.2/include -Ideps/unique_resource/cba309e -Ideps/unique_resource/cba309e/include -Ideps/variant/1.1.4 -Ideps/variant/1.1.4/include -Ideps/vector-tile/1.0.0-rc7 -Ideps/vector-tile/1.0.0-rc7/include -Ideps/wagyu/0.4.3 -Ideps/wagyu/0.4.3/include -Iinclude -Iplatform/default -Iplatform/qt -Iplatform/qt/include -Isrc -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork/5.9.3/QtNetwork -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui/5.9.3/QtGui -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql/5.9.3/QtSql -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore/5.9.3 -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore/5.9.3/QtCore -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtNetwork -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtGui -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtSql -isystem /nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/include/QtCore -I.moc -isystem /nix/store/8ksm7l0wpd0mzgs5h4wb7chq823rdqcj-mesa-noglu-17.2.8-dev/include -I/nix/store/crz9bmm0yhcx4sxm9cr9i2d12zaxznwq-qtbase-5.9.3-dev/mkspecs/linux-g++ -o .obj/src/mbgl/style/conversion/layer.o src/mbgl/style/conversion/layer.cpp
building of '/nix/store/xxmbsgng88m9rk3l1f6s01b5fs4g3wdv-qtlocation-5.9.3.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/a5icn98dzvsbkqbn4ds0dkhrbril79p9-qtwebengine-5.9.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xc5pa0rzdxny5pdvrkhczxyr99zck3qi-qtwebkit-5.9.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/znis7k3sf7ggnqm7gr12qdvr34k8djkv-python3.6-PyQt-5.9.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/r5qf9m9b0b51y4kd31sh7p1f26d2yzxr-electrum-3.0.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/r5qf9m9b0b51y4kd31sh7p1f26d2yzxr-electrum-3.0.4.drv' failed

@joachifm joachifm added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 7, 2018
@joachifm joachifm merged commit fb2e3e9 into NixOS:master Jan 7, 2018
@joachifm
Copy link
Contributor

joachifm commented Jan 7, 2018

Thank you. Backporting as well.

@joachifm
Copy link
Contributor

joachifm commented Jan 7, 2018

Backported.

@erictapen
Copy link
Member Author

Nice, very good.

@erictapen erictapen deleted the electrum-3.0.4 branch January 7, 2018 14:48
@rnhmjoj rnhmjoj mentioned this pull request Jan 7, 2018
Merged
8 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erictapen @adisbladis @joachifm @GrahamcOfBorg @samueldr