uhd: apply upstream patch to fix build w/boost 1.66 #33552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build uhd |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
--:
--:-
-
0:00
:01
3667
9
cannot build derivation ‘/nix/store/ala10w98gr0as7jzkpgbnnnsslryj6hp-uhd-3.10.2.0.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/ala10w98gr0as7jzkpgbnnnsslryj6hp-uhd-3.10.2.0.drv’ failed
There was a problem hiding this comment.
Success for system: aarch64-linux
uhd-images_003.007.003-release/share/uhd/images/usrp_n200_r2_fpga.bin
uhd-images_003.007.003-release/share/uhd/images/usrp_b200_fw.hex
uhd-images_003.007.003-release/share/uhd/images/usrp1_fpga.rbf
uhd-images_003.007.003-release/share/uhd/images/usrp_b100_fpga.bin
uhd-images_003.007.003-release/share/uhd/images/003.007.003.tag
uhd-images_003.007.003-release/share/uhd/images/usrp_x310_fpga_HGS.lvbitx
uhd-images_003.007.003-release/share/uhd/images/usrp_n210_r2_fpga.bin
uhd-images_003.007.003-release/share/uhd/images/usrp_x300_fpga_HGS.lvbitx
uhd-images_003.007.003-release/share/uhd/images/usrp_n200_r4_fpga.bin
/nix/store/9hv37si96cr6334vvmvxdh5z7pf8icvg-uhd-3.10.2.0
There was a problem hiding this comment.
Success for system: x86_64-linux
uhd-images_003.007.003-release/share/uhd/images/usrp_n200_r2_fpga.bin
uhd-images_003.007.003-release/share/uhd/images/usrp_b200_fw.hex
uhd-images_003.007.003-release/share/uhd/images/usrp1_fpga.rbf
uhd-images_003.007.003-release/share/uhd/images/usrp_b100_fpga.bin
uhd-images_003.007.003-release/share/uhd/images/003.007.003.tag
uhd-images_003.007.003-release/share/uhd/images/usrp_x310_fpga_HGS.lvbitx
uhd-images_003.007.003-release/share/uhd/images/usrp_n210_r2_fpga.bin
uhd-images_003.007.003-release/share/uhd/images/usrp_x300_fpga_HGS.lvbitx
uhd-images_003.007.003-release/share/uhd/images/usrp_n200_r4_fpga.bin
/nix/store/c7zq8jhazwpn4zb3a5r9ya95dgasg9hs-uhd-3.10.2.0
8 tasks
|
@dtzWill is this tested and good to go? |
|
I was responding to the issue/build failure, which this fixes. But I'm not sure how to test the resulting derivation "works"-- although since this is a minor change from upstream I expect it works as well as it did previously. |
|
Thanks for fixing it. Unfortunately, I can't test it either. I opened #33549 since uhd is needed by gnuradio. |
|
Closing (this PR seems to be wrong approach) in favor of updating to 3.10.3.0 when it's released. Should be soon... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33549.
Motivation for this change
Grab upstream patch for fixing compat with boost 1.66.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)