Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taxonomy improvements #2943

Merged
merged 2 commits into from Jan 7, 2018
Merged

Taxonomy improvements #2943

merged 2 commits into from Jan 7, 2018

Conversation

felixfontein
Copy link
Contributor

Simplified code a bit, and avoided collision check for non-generated classifications.

Kwpolska
Kwpolska approved these changes Jan 7, 2018
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I hope you tested this as well.

@Kwpolska Kwpolska merged commit f37b51f into master Jan 7, 2018
@Kwpolska Kwpolska deleted the taxonomy-improvements branch January 7, 2018 17:24
@felixfontein
Copy link
Contributor Author

Thanks!

I tested it with all of my blogs, seems to work fine.
I improved the collision check since I actually got such a collision; after adding this check, it worked as it should (i.e. only test "real" collisions).

So I guess it should be good enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @Kwpolska