Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab runner 10.3.0 #33571

Merged
merged 2 commits into from Jan 7, 2018
Merged

Gitlab runner 10.3.0 #33571

merged 2 commits into from Jan 7, 2018

Conversation

bachp
Copy link
Member

@bachp bachp commented Jan 7, 2018

Motivation for this change

Update to latest version.

The remarshall update is required as 0.6.0 does not build anymore which breaks the gitlab-runner module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The checks in 0.6.0 did no longer work with the updated dependencies.
Updating to 0.7.0 fixes the issue.

The deps.nix file was used for the go version and is no longer required
as remarshal is now written in python.
@globin
Copy link
Member

globin commented Jan 7, 2018

@GrahamcOfBorg build gitlab-runner

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

building '/nix/store/waq6f4jk78p1pp03p7lpzj2k5frxzrv9-remove-references-to.drv'...
copying path '/nix/store/z229afq6xfq5ic7x4m0qx0yzdy9aqhn2-parallel-20171022' from 'https://cache.nixos.org'...
building '/nix/store/anwvh6krkjwcvx7nyplrasn9xzbx3mx8-prebuilt-arm.tar.xz.drv'...
building '/nix/store/nw15nfswsx36asmg80kfrbbgv9vfq60y-prebuilt-x86_64.tar.xz.drv'...

trying https://gitlab-runner-downloads.s3.amazonaws.com/v10.3.0/docker/prebuilt-arm.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
copying path '/nix/store/0w782kwkhbqiqa6drjyialqmyq886mha-go-bindata-20151023-a0ff256' from 'https://cache.nixos.org'...
error: all build users are currently in use; consider creating additional users and adding them to the 'nixbld' group

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/ci/version: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/ci/release_docker_images: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/ci/release_s3: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/ci/build_ci_image: interpreter directive changed from "/bin/bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/ci/release_packagecloud: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/bash"
/nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/packaging/root/usr/share/gitlab-runner/clear-docker-cache: interpreter directive changed from "/bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
/nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/packaging/root/usr/share/gitlab-runner/pre-remove: interpreter directive changed from "/bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
/nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/packaging/root/usr/share/gitlab-runner/post-install: interpreter directive changed from "/bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-gitlab-runner-10.3.0.drv-0 in /nix/store/wfha2xiqyf0wzj6616j8w7mdm2gk2am8-gitlab-runner-10.3.0...
/nix/store/s7m4akk1vfjxxx3lblyd4vrsb2cjr5iz-gitlab-runner-10.3.0-bin

@globin globin merged commit e9519ba into NixOS:master Jan 7, 2018
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

/nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/tests/test_installation.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/ugorji/go/codec/prebuild.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/ugorji/go/codec/tests.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/distribution/coverpkg.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/getsentry/raven-go/runtests.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash"
/nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0/share/go/src/gitlab.com/gitlab-org/gitlab-runner/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/bash -e"
checking for references to /build in /nix/store/ci50dz4qgyrxca2g96ny7wcvvgqv8f82-gitlab-runner-10.3.0...
/nix/store/ln1cqpgpdackiz2rjkiza1xr0c5w0505-gitlab-runner-10.3.0-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants