Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtools: 2.075.1 -> 2.078.0 #33543

Merged
merged 1 commit into from Jan 8, 2018
Merged

dtools: 2.075.1 -> 2.078.0 #33543

merged 1 commit into from Jan 8, 2018

Conversation

ThomasMader
Copy link
Contributor

@ThomasMader ThomasMader commented Jan 6, 2018

Motivation for this change

dtools: 2.075.1 -> 2.078.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2018

Is it reasonable to keep rdmd_test installed? (Is there any use case beyond our checkPhase?)

$ /nix/store/z28shj7a8g2n4phsavkfis3rihlws80x-dtools-2.078.0/bin/rdmd_test
object.Exception@rdmd_test.d(63): Path to rdmd does not exist: rdmd.d
----------------
??:? pure @safe void std.exception.bailOut!(Exception).bailOut(immutable(char)[], ulong, const(char[])) [0x48fbde]
??:? pure @safe bool std.exception.enforce!(Exception, bool).enforce(bool, lazy const(char)[], immutable(char)[], ulong) [0x4943c8]
??:? _Dmain [0x489377]

@ThomasMader
Copy link
Contributor Author

Is it reasonable to keep rdmd_test installed? (Is there any use case beyond our checkPhase?)

No, removed it.

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2018

@GrahamcOfBorg build dtools

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘dmdBuild-2.078.0’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/compilers/dmd/default.nix:230 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin


 0:00:
01 --:
--:--
 0:00:
01 3354
8

cannot build derivation ‘/nix/store/78wc9c6w1g8351jp26a4s6dpn2zlkd0m-dtools-2.078.0.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/78wc9c6w1g8351jp26a4s6dpn2zlkd0m-dtools-2.078.0.drv’ failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/changed
shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/tolf
shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/checkwhitespace
shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/dget
shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/dustmite
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin 
patching script interpreter paths in /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0
checking for references to /tmp/nix-build-dtools-2.078.0.drv-0 in /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0...
/nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0

@ThomasMader
Copy link
Contributor Author

And again the bot build isn't working on Mac OSX. See also #33532 (comment)

@Mic92
Copy link
Member

Mic92 commented Jan 8, 2018

@GrahamcOfBorg build dtools

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

-:--
0

100  7280  10
0  7280    0     0   7280
0  0:00:01 --:--:-
-  0:00:01 267
64

cannot build derivation ‘/nix/store/78wc9c6w1g8351jp26a4s6dpn2zlkd0m-dtools-2.078.0.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/78wc9c6w1g8351jp26a4s6dpn2zlkd0m-dtools-2.078.0.drv’ failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/tolf
shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/dget
shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/rdmd
shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/contributors
shrinking /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin/dustmite
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0/bin 
patching script interpreter paths in /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0
checking for references to /tmp/nix-build-dtools-2.078.0.drv-0 in /nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0...
/nix/store/v4jqx3xh5xn5s3pd0ss2c3b4zvzdbb64-dtools-2.078.0

@Mic92 Mic92 merged commit d273f02 into NixOS:master Jan 8, 2018
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘dmdBuild-2.078.0’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/compilers/dmd/default.nix:230 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@ThomasMader ThomasMader deleted the dtools2.078.0 branch January 10, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants