Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbladeRF: 1.4.0 -> 1.9.0 #33551

Merged
merged 4 commits into from Jan 12, 2018
Merged

libbladeRF: 1.4.0 -> 1.9.0 #33551

merged 4 commits into from Jan 12, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Update libbladeRF from its 2015 release (1.4.0) which fails to build on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2018

@GrahamcOfBorg build libbladeRF

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: while evaluating the attribute 'buildInputs' of the derivation 'libbladeRF-v1.9.0' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:134:11:
while evaluating 'getOutput' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/attrsets.nix:450:23, called from undefined position:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/stdenv/generic/make-derivation.nix:85:17, called from undefined position:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/top-level/all-packages.nix:13298:13:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/systemd/default.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/lib/customisation.nix:74:12:
assertion failed at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/systemd/default.nix:9:1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

shrinking RPATHs of ELF executables and libraries in /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0
shrinking /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0/bin/bladeRF-fsk
shrinking /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0/bin/bladeRF-cli
shrinking /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0/lib/libbladeRF.so.1
gzipping man pages under /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0/share/man/
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0/lib  /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0/bin
patching script interpreter paths in /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0
checking for references to /build in /nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0...
/nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking RPATHs of ELF executables and libraries in /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0
shrinking /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/bin/bladeRF-cli
shrinking /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/bin/bladeRF-fsk
shrinking /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/lib/libbladeRF.so.1
gzipping man pages under /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/lib  /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/bin 
patching script interpreter paths in /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0
checking for references to /tmp/nix-build-libbladeRF-v1.9.0.drv-0 in /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0...
/nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0

@@ -35,6 +35,6 @@ stdenv.mkDerivation rec {
description = "Supporting library of the BladeRF SDR opensource hardware";
license = licenses.lgpl21;
maintainers = with maintainers; [ funfunctor ];
platforms = platforms.linux;
platforms = with platforms; linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might work on darwin, if udev was made optional.
However we should probably let somebody test it on the platform first.

Copy link
Member Author

@markuskowa markuskowa Jan 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to their web page this package should support Darwin but I have no to possibility to test it.
I'll give it a try and make udev optional.

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2018

@GrahamcOfBorg build libbladeRF

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

/nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

0

100  121k  100  1
21k    0
0   12
1k      0  0:
00:01 --:--:--
0:00:01  238k

cannot build derivation ‘/nix/store/7bclmzcnddypzsqddlvz924wy23c7g30-libbladeRF-v1.9.0.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/7bclmzcnddypzsqddlvz924wy23c7g30-libbladeRF-v1.9.0.drv’ failed

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2018

@GrahamcOfBorg build libbladeRF

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

/nix/store/32ycbar914qhlddzv5jbaasc9118dd5g-libbladeRF-v1.9.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

  libusb v1.0.18 is required in OS X.  Please update libusb.Detected version:
  0.0.0



-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-libbladeRF-v1.9.0.drv-0/source/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-libbladeRF-v1.9.0.drv-0/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/7bclmzcnddypzsqddlvz924wy23c7g30-libbladeRF-v1.9.0.drv' failed with exit code 1
error: build of '/nix/store/7bclmzcnddypzsqddlvz924wy23c7g30-libbladeRF-v1.9.0.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking RPATHs of ELF executables and libraries in /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0
shrinking /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/bin/bladeRF-cli
shrinking /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/bin/bladeRF-fsk
shrinking /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/lib/libbladeRF.so.1
gzipping man pages under /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/lib  /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0/bin 
patching script interpreter paths in /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0
checking for references to /tmp/nix-build-libbladeRF-v1.9.0.drv-0 in /nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0...
/nix/store/hpzaw3ljx8i388rmwwxi5fdmjgrv3vrz-libbladeRF-v1.9.0

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2018

Some quirk in the cmake build system, when detecting libusb: https://github.com/Nuand/bladeRF/blob/fcd775f2b92bcb3cb70781df5824ca7ddfc3e00f/host/cmake/modules/FindLibUSB.cmake#L66

But I don't know the actual root cause.

@markuskowa
Copy link
Member Author

markuskowa commented Jan 7, 2018

This seems hard to fix and test without a mac. I suggest reverting the last commit and go with linux platform only. The old version was linux only too.

@Mic92
Copy link
Member

Mic92 commented Jan 8, 2018

yes

@Mic92 Mic92 merged commit 6bbf503 into NixOS:master Jan 12, 2018
@markuskowa markuskowa deleted the bladerf-fix-pr branch January 19, 2018 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants