readline: Don't attempt to check for broken wcwidth #33576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzWill
force-pushed
the
fix/cross-readline
branch
from
2a7c83d
to
ea9b872
Compare
Ericson2314
reviewed
Jan 8, 2018
| @@ -16,6 +16,12 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| patchFlags = "-p0"; | |||
|
|
|||
| configureFlags = | |||
| stdenv.lib.optional (stdenv.hostPlatform != stdenv.buildPlatform) | |||
| [ # This test requires running target code | |||
The test requires running code on the target.
Ericson2314
force-pushed
the
fix/cross-readline
branch
from
ea9b872
to
dc8bd43
Compare
|
Tested, in this configure test forcing is indeed still needed. Thanks you both! |
Ericson2314
added
the
6.topic: cross-compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test requires running code on the target.
Motivation for this change
Before this change, readline does not currently build when cross-compiling.
Reviewers can confirm by trying this with and without this fix:
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)