Fix wrongly positioned popups (LP: #1527013).

lubuntu-team · Feb 6, 2018 · f274b6d · f274b6d
1 parent 4f09818
commit f274b6d
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 0 deletions.
diff --git a/debian/changelog b/debian/changelog
@@ -1,3 +1,13 @@
+lxqt-panel (0.12.0-8ubuntu1) UNRELEASED; urgency=medium
+
+  * Cherry-pick some upstream commits because the upstream release cycle is
+    horribly slow (and without this it'll be years before they come in):
+    - Fix wrongly positioned popups (LP: #1527013).
+      + fix-wrongly-positioned-popups.patch
+      + Upstream commit 7391172.
+
+ -- Simon Quigley <tsimonq2@ubuntu.com>  Mon, 05 Feb 2018 19:00:18 -0600
+
 lxqt-panel (0.12.0-8build1) bionic; urgency=medium
 
   * No change rebuild against libdbusmenu-qt5-2.

diff --git a/debian/patches/fix-wrongly-positioned-popups.patch b/debian/patches/fix-wrongly-positioned-popups.patch
@@ -0,0 +1,30 @@
+Description: lxqtpanel: Fix wrongly positioned popups
+ Avoid the usage the QWidget::mapToGlobal(), which is unreliable sometimes.
+Author: Palo Kisa <palo.kisa@gmail.com>
+Origin: backport
+Bug: https://github.com/lxde/lxqt/issues/1076
+Bug-Ubuntu: https://pad.lv/1527013
+Applied-Upstream: commit:7391172
+Last-Update: 2018-02-05
+--- a/panel/lxqtpanel.cpp
++++ b/panel/lxqtpanel.cpp
+@@ -987,7 +987,8 @@ void LXQtPanel::setReserveSpace(bool res
+  ************************************************/
+ QRect LXQtPanel::globalGometry() const
+ {
+-    return QRect(mapToGlobal(QPoint(0, 0)), this->size());
++    // panel is the the top-most widget/window, no calculation needed
++    return geometry();
+ }
+
+
+@@ -1204,7 +1205,8 @@ QRect LXQtPanel::calculatePopupWindowPos
+         return QRect();
+     }
+
+-    return calculatePopupWindowPos(panel_plugin->mapToGlobal(QPoint(0, 0)), windowSize);
++    // Note: assuming there are not contentMargins around the "BackgroundWidget" (LXQtPanelWidget)
++    return calculatePopupWindowPos(globalGeometry().topLeft() + panel_plugin->geometry().topLeft(), windowSize);
+ }
+
+
diff --git a/debian/patches/series b/debian/patches/series
@@ -1,3 +1,6 @@
 clock-and-volume.patch
 move-configs.patch
 plugin-volume-mixer.patch
+
+# Ubuntu-specific patches
+fix-wrongly-positioned-popups.patch