Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-netgame, observers are listed with players #302

Closed
SimonN opened this issue Feb 5, 2018 · 2 comments
Closed

Post-netgame, observers are listed with players #302

SimonN opened this issue Feb 5, 2018 · 2 comments
Labels
3-bug

Comments

@SimonN
Copy link
Owner

SimonN commented Feb 5, 2018

Lix 0.9.10.

Observe a networking game. Have other people finish the game. You will be listed with the team that you observed.

Expected: You're not listed at all.
@SimonN SimonN added the 3-bug label Feb 5, 2018
@SimonN
Copy link
Owner Author

SimonN commented Feb 25, 2018

The observer is listed on the output to the ingame/lobby console.

The end-of-multiplayer window is not shown for that observer anyway.

@SimonN
Copy link
Owner Author

SimonN commented Feb 26, 2018

Should be fixed in 0.9.13.

Also, replays will be agnostic about who was the local player, and who were the remote players. Only the interactive game needs to know who is local.

In a networking game, the game will ask the networking client, and in a replay, we look at who matches our username that we typed in the options dialog. If nobody matches, a style at random will be observed.

@SimonN SimonN closed this as completed in 6b60018 Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SimonN