Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphviz: Explicitly specify libltdl directories #34640

Merged
merged 1 commit into from Feb 9, 2018
Merged

graphviz: Explicitly specify libltdl directories #34640

merged 1 commit into from Feb 9, 2018

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Feb 5, 2018 •
edited

Motivation for this change

When building graphviz on non-NixOS systems without chroot, the autotools-build picks up the library "/usr/lib/libltdl.so" instead of the one provided by nix. Explicitly specifying the library fixes the impurity.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@knedlsepp
graphviz: Explicitly specify libltdl directories
ceeacd5 
This should prevent the build from picking up /usr/lib/libltdl.so in
non-chroot builds on non-nixOS.
@Mic92
Copy link
Member

Mic92 commented Feb 9, 2018

Please move this pr from the master branch to the staging branch as it triggers a mass-rebuild.

@FRidh FRidh changed the base branch from master to staging February 9, 2018 18:59
@FRidh FRidh merged commit 8754d64 into NixOS:staging Feb 9, 2018
@knedlsepp knedlsepp deleted the reduce-graphviz-impurity branch February 16, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knedlsepp @Mic92 @FRidh @GrahamcOfBorg