Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: 7.57.0 -> 7.58.0 #34256

Closed
wants to merge 1 commit into from
Closed

curl: 7.57.0 -> 7.58.0 #34256

wants to merge 1 commit into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Fixes #34220 but causes a lot of rebuilding.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Jan 25, 2018

Could you change the base to staging and rebase?

@peterhoeg peterhoeg changed the base branch from master to staging January 26, 2018 01:15
@peterhoeg
Copy link
Member Author

Done @globin

@Ericson2314 Ericson2314 removed their request for review January 26, 2018 17:14
@vcunat
Copy link
Member

vcunat commented Feb 3, 2018

We have 60331e6 on staging and 853a6fe on 17.09.

@vcunat vcunat closed this Feb 3, 2018
@peterhoeg peterhoeg deleted the u/curl branch February 5, 2018 05:48
@peterhoeg peterhoeg restored the u/curl branch February 5, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @globin @vcunat @GrahamcOfBorg