Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gthumb: 3.5.3 -> 3.6.0 #34254

Merged
merged 1 commit into from Jan 25, 2018
Merged

gthumb: 3.5.3 -> 3.6.0 #34254

merged 1 commit into from Jan 25, 2018

Conversation

mimame
Copy link
Member

@mimame mimame commented Jan 25, 2018

Motivation for this change

Update gthumb to the last version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Wanted to test this out, but both the old and the new version seem to not work for me, going to a folder with pictures in it shows it as empty. I am getting the following seemingly related errors when starting it:

(gthumb:8477): GLib-GIO-CRITICAL **: g_file_new_for_path: assertion 'path != NULL' failed
(gthumb:8477): GLib-GIO-CRITICAL **: g_file_get_uri: assertion 'G_IS_FILE (file)' failed
(gthumb:8477): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)'
 failed

@jtojnar
Copy link
Contributor

jtojnar commented Jan 25, 2018

Works for me, thanks.

@jtojnar jtojnar merged commit 3f88d9d into NixOS:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mimame @infinisil @jtojnar @GrahamcOfBorg