Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ref to mkstemps in ARM #5640

Merged
merged 1 commit into from Feb 25, 2018
Merged

Missing ref to mkstemps in ARM #5640

merged 1 commit into from Feb 25, 2018

Conversation

blankoworld
Copy link
Contributor

Should fix #5264 for ARM architecture.

I recently have to compile something in ARM architecture and the compilation was broken.

Fixing this line permits to finish the compilation.

What I don't know is why this line was not added before? Is there a problem with it on ARM architecture?

How could I check that all is OK about this?

@blankoworld
Missing ref to mkstemps in ARM
db3d013 
Should fix #5264 for ARM architecture
@ysbaddaden
Copy link
Contributor

It was probably overlooked, since we don't have an ARM target on CI... Can you run specs related to Tempfile on the ARM target?

@blankoworld
Copy link
Contributor Author

I tried on my Olimex, but it doesn't work. I read that it could works on a RPi?

Is there some documentation to use/compile/install Crystal on RPi (1, 2 or 3) so that I can check specs you're talking about?

At home I have RPi 1 B+, 2 and 3. So just ask me what I have to do ^_^

@opiation
Copy link
Contributor

opiation commented Feb 25, 2018 •
edited

I'm guessing by Tempfile specs, @ysbaddaden is referring to a selection of specs run when using make spec verbose=1. After compiling Crystal 0.24.1 on a Pi 3 with LLVM 5.0.1 and @ysbaddaden's repo which currently ships with Crystal 0.23.1, I was able to compile and run all specs by adding the line proposed in this change. It's absence indeed appears to be an oversight.

@ysbaddaden ysbaddaden merged commit 91a025f into crystal-lang:master Feb 25, 2018
@RX14 RX14 added this to the Next milestone Feb 25, 2018
@blankoworld blankoworld deleted the patch-1 branch February 26, 2018 12:04
@faustinoaq faustinoaq mentioned this pull request Mar 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blankoworld @ysbaddaden @opiation @RX14