Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron: 1.7.9 -> 1.7.11 #34618

Merged
merged 1 commit into from Feb 5, 2018
Merged

electron: 1.7.9 -> 1.7.11 #34618

merged 1 commit into from Feb 5, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Feb 5, 2018

Motivation for this change

Upstream releases:
https://github.com/electron/electron/releases/tag/v1.7.10
https://github.com/electron/electron/releases/tag/v1.7.11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS x86_64 and i686
    • macOS
    • arm
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" --- tested one dependent app: marp
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@domenkozar
Copy link
Member

@GrahamcOfBorg build electron

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘electron-1.7.11’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/tools/electron/default.nix:10 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

  inflating: /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib/electron/locales/nb.pak  
shrinking RPATHs of ELF executables and libraries in /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11
shrinking /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib/electron/libffmpeg.so
shrinking /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib/electron/libnode.so
shrinking /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib/electron/electron
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/lib  /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11/bin 
patching script interpreter paths in /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11
checking for references to /tmp/nix-build-electron-1.7.11.drv-0 in /nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11...
/nix/store/pr9r5022chmh59v29mfv3s5s4m3wc11f-electron-1.7.11

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Headers -> Versions/Current/Headers
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Modules -> Versions/Current/Modules
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/ReactiveCocoa -> Versions/Current/ReactiveCocoa
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Resources -> Versions/Current/Resources
  Electron.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current -> A
  Electron.app/Contents/Frameworks/Squirrel.framework/Headers -> Versions/Current/Headers
  Electron.app/Contents/Frameworks/Squirrel.framework/Modules -> Versions/Current/Modules
  Electron.app/Contents/Frameworks/Squirrel.framework/Resources -> Versions/Current/Resources
  Electron.app/Contents/Frameworks/Squirrel.framework/Squirrel -> Versions/Current/Squirrel
  Electron.app/Contents/Frameworks/Squirrel.framework/Versions/Current -> A

@domenkozar domenkozar merged commit 4250f50 into NixOS:master Feb 5, 2018
@rvl rvl mentioned this pull request Feb 5, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvl @domenkozar @GrahamcOfBorg