Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains-editor: 2017.3.2 -> 2017.3.4 #34622

Merged
merged 5 commits into from Feb 5, 2018
Merged

jetbrains-editor: 2017.3.2 -> 2017.3.4 #34622

merged 5 commits into from Feb 5, 2018

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Feb 5, 2018

Motivation for this change

Minor updates to 2017.3.4

Things done

Tested only idea-ultimate.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jokogr jokogr requested a review from edwtjo as a code owner February 5, 2018 12:31
@andir
Copy link
Member

andir commented Feb 5, 2018

Thanks @jokogr ! 👍

@andir andir merged commit 30d9de9 into NixOS:master Feb 5, 2018
@jokogr jokogr deleted the u/jetbrains-2017.3.4 branch February 9, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jokogr @andir @GrahamcOfBorg