Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack overhead #3143

Merged
merged 2 commits into from Feb 6, 2018
Merged

Fix stack overhead #3143

merged 2 commits into from Feb 6, 2018

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Feb 5, 2018 •
edited

Proposed Changes

  • Separate debug definitions into hpx/config/debug.hpp
  • Include debug.hpp in the new threads_stack.hpp config file

Any background context you want to provide?

This is the same as #3097, but makes sure HPX_DEBUG is defined for the thread stacksize defines.

sithhell
sithhell approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@hkaiser hkaiser added this to the 1.1.0 milestone Feb 5, 2018
hkaiser
hkaiser reviewed Feb 5, 2018
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original fix also factored out into a separate file the stack size definitions. Should we still do that before merging?

@hkaiser
Copy link
Member

hkaiser commented Feb 5, 2018

The original fix also factored out into a separate file the stack size definitions. Should we still do that before merging?

Ohh, I'm blind, please disregard what I said. This LGTM!

@hkaiser hkaiser merged commit f48ac14 into STEllAR-GROUP:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser left review comments

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
category: core category: threadmanager type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msimberg @hkaiser @sithhell