htop: 2.02 -> 2.1.0 #34625
htop: 2.02 -> 2.1.0 #34625
Conversation
pkgs/tools/system/htop/default.nix
Outdated
| }; | ||
|
|
||
| buildInputs = | ||
| [ ncurses ] ++ | ||
| [ ncurses python ] ++ |
There was a problem hiding this comment.
Isn't it sufficient to put this in nativeBuildInputs?
There was a problem hiding this comment.
Indeed 👍
It's only used for build time code generation
pkgs/tools/system/htop/default.nix
Outdated
| lib.optionals stdenv.isDarwin [ IOKit ]; | ||
|
|
||
| patchPhase = '' |
There was a problem hiding this comment.
I think it's better to use post/prePatch.
There was a problem hiding this comment.
Yes, either is fine. I always tend to use prePatch. You should usually not touch the patchPhase unless really required. If we ever need the standard patches attribute with this derivation not having to rename other attributes would be great :-)
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "htop-${version}"; | ||
| version = "2.0.2"; |
There was a problem hiding this comment.
Your commit message states 2.02. Can you please change that to 2.0.2?
pkgs/tools/system/htop/default.nix
Outdated
| lib.optionals stdenv.isDarwin [ IOKit ]; | ||
|
|
||
| patchPhase = '' |
There was a problem hiding this comment.
Yes, either is fine. I always tend to use prePatch. You should usually not touch the patchPhase unless really required. If we ever need the standard patches attribute with this derivation not having to rename other attributes would be great :-)
|
@dotlambda Thanks for the feedback. Done. |
|
Thanks! :) |
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)