-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assaultcube: init at official master branch , rev = "9f537b0876a39d7686e773040469fbb1417de18b" #34623
Conversation
pkgs/games/assaultcube/default.nix
Outdated
@@ -0,0 +1,80 @@ | |||
{ fetchgit, stdenv, makeDesktopItem, curl, enet, openal, pkgconfig, libogg, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl and SDL_mixer are never used, as far as I can see.
pkgs/games/assaultcube/default.nix
Outdated
stdenv.mkDerivation rec { | ||
|
||
# master branch has legacy (1.2.0.2) protocol 1201 and gcc 6 fix. | ||
branch = "master"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have some sort of version attribute here, appended to name? Perhaps just the date of the commit in question.
pkgs/games/assaultcube/default.nix
Outdated
}; | ||
|
||
#sadless , fetchgit seems to refetch all stuff when man switch branch . | ||
src = fetchgit { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fetchFromGitHub would be preferable here.
pkgs/games/assaultcube/default.nix
Outdated
url = "https://github.com/assaultcube/AC.git"; | ||
rev = "9f537b0876a39d7686e773040469fbb1417de18b"; | ||
branchName = "${branch}"; | ||
#sha256 = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a hash!
@GrahamcOfBorg build assaultcube |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
@GrahamcOfBorg build assaultcube |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Motivation for this change
fun first-person-shooter, need to build on git since latest official release is out of date (2013) ...
Things done
Tested only on my non-nixos OS (gentoo ~amd64) . I've (so common) gl issues , but this old good games since to work well.