Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

busybox shell: enable various useful/expected features #1842

Merged
merged 1 commit into from Feb 22, 2018
Merged

busybox shell: enable various useful/expected features #1842

merged 1 commit into from Feb 22, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 5, 2018 •
edited

Matches changes made in nixpkgs:
NixOS/nixpkgs#34628

Fixes #1832 .

@copumpkin
Copy link
Member

Surprised to see isLinux in the configureFlags (not in your PR, but in this file) when busybox isn't supported on other platforms as far as I know

@dtzWill
Copy link
Member Author

dtzWill commented Feb 5, 2018

Err, busybox not being supported on non-Linux is why its used is guarded by the isLinux check. Right?

@copumpkin
Copy link
Member

Oh sorry, I misread the indentation 😄

@dtzWill dtzWill mentioned this pull request Feb 5, 2018
Merged
@edolstra edolstra merged commit 0ffa615 into NixOS:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @copumpkin @edolstra