Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireguard: 0.0.20180118 -> 0.0.20180202 #34621

Merged
merged 1 commit into from Feb 5, 2018
Merged

wireguard: 0.0.20180118 -> 0.0.20180202 #34621

merged 1 commit into from Feb 5, 2018

Conversation

zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Feb 5, 2018

Simple version bump.

  * curve25519-fiat32: uninline certain functions
  
  This results in much smaller code size and significanat speed gains on smaller
  hardware.
  
  * poly1305: add poly-specific self-tests
  
  Poly is easy to get wrong, so we've added quite a few tests that examine
  certain edge cases and places where other implementations of historically
  failed.
  
  * tools: dedup secret normalization
  * tools: share curve25519 implementations with kernel
  * contrib: keygen-html: share curve25519 implementation with kernel
  
  There is now only one place where we ship 25519 code.
  
  * qemu: disable PIE for compilation
  * qemu: disable AVX-512 in userland
  * qemu: update base versions
  
  Test suite enhancements.
  
  * device: let udev know what kind of device we are
  
  This enables folks to query the device type via udev, which is what systemd's
  networkctl uses.
  
  * tools: fread doesn't change errno
  
  This fixes clearing pre-shared keys on old glibc.
  
  * chacha20poly1305: use existing rol32 function
  * chacha20poly1305: better buffer alignment
  
  Small enhancements.
  
  * curve25519: verify that specialized basepoint implementations are correct
  
  Since some implementations have a specialized function for computing
  basepoints, it's important to do some basic sanity checking with them.
  
  * curve25519: replace hacl64 with fiat64
  
  For about 24 hours, fiat64 was faster.
  
  * curve25519: replace fiat64 with faster hacl64
  
  Then hacl64 caught up, so we moved back to it.
  
  * curve25519: break more things with more test cases
  
  These extra test cases help break the current "rfc7748_precomputed"
  implementation, which we're not using here at the moment, but it is still
  useful to ensure that we don't fall victim to the same bugs.

@andir
Copy link
Member

andir commented Feb 5, 2018

@GrahamcOfBorg build linuxPackages_testing.wireguard linuxPackages_latest.wireguard linuxPackages.wireguard linuxPackages_4_15.wireguard linuxPackages_hardened.wireguard

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13136:17:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/wireguard/default.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
while evaluating the attribute 'linux_testing' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:12967:3:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:12967:19:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-testing.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-testing.nix:3:1:
assertion failed at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:33:1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/kjz8djrzljcjq7vdks9yj55mk5ff4i1h-wireguard-0.0.20180202
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/kjz8djrzljcjq7vdks9yj55mk5ff4i1h-wireguard-0.0.20180202/lib
patching script interpreter paths in /nix/store/kjz8djrzljcjq7vdks9yj55mk5ff4i1h-wireguard-0.0.20180202
checking for references to /build in /nix/store/kjz8djrzljcjq7vdks9yj55mk5ff4i1h-wireguard-0.0.20180202...
/nix/store/kjz8djrzljcjq7vdks9yj55mk5ff4i1h-wireguard-0.0.20180202
/nix/store/mjhxz0hl0bpl3dnnp21f14jyxq84a54f-wireguard-0.0.20180202
/nix/store/5imc1b20y2vpcgiadw4n6plafg71b22f-wireguard-0.0.20180202
/nix/store/mjhxz0hl0bpl3dnnp21f14jyxq84a54f-wireguard-0.0.20180202
/nix/store/5vm3p11azpfc9zh74d6i09zrkmb6ikj5-wireguard-0.0.20180202

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

install flags: install
  INSTALL /tmp/nix-build-wireguard-0.0.20180202.drv-0/WireGuard-0.0.20180202/src/wireguard.ko
  DEPMOD  4.15.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/87s2riji72md3axn42dbc8jlf2yaddkn-wireguard-0.0.20180202
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/87s2riji72md3axn42dbc8jlf2yaddkn-wireguard-0.0.20180202/lib 
patching script interpreter paths in /nix/store/87s2riji72md3axn42dbc8jlf2yaddkn-wireguard-0.0.20180202
checking for references to /tmp/nix-build-wireguard-0.0.20180202.drv-0 in /nix/store/87s2riji72md3axn42dbc8jlf2yaddkn-wireguard-0.0.20180202...
error: build of ‘/nix/store/zxwnbmlgxqp3r6ys23hjrgvai166dd00-wireguard-0.0.20180202.drv’ failed

@andir
Copy link
Member

andir commented Feb 5, 2018

Failure due to 1800s timeout. I tested it on one of my machines using nox-review and all kernel versions seem to work fine.

Thanks for keeping it updated @zx2c4 ! 👍

@andir andir merged commit db99677 into NixOS:master Feb 5, 2018
@andir
Copy link
Member

andir commented Feb 5, 2018

Backported in 4670974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zx2c4 @andir @GrahamcOfBorg